[ROCm EP] Fix transpose helpler via removing default trivial constructor #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eck via CanUse_hipBlasTransposeHelper_MLFloat16
TedThemistokleous
merged commit bb933d4
into
rocm6.4_internal_testing
5 of 15 checks passed
tianleiwu
pushed a commit
to microsoft/onnxruntime
that referenced
this pull request
Jan 29, 2025
Remove inline default transposeHelper and ensure we use the proper check via CanUse_hipBlasTransposeHelper_MLFloat16 Related to change in ROCm Onnxruntime repo: ROCm#82 ### Description Required to correctly limit grid size of transpose helper kernel ### Motivation and Context Compile was defaulting to the inline constructor that was removed instead of using the overloaded case with proper checks. Removed the inline default "true" case as this is incorrect for newer AMD cards/targets Co-authored-by: Ted Themistokleous <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove inline default transposeHelper and ensure we use the proper cjeck via CanUse_hipBlasTransposeHelper_MLFloat16
Motivation and Context
Required as some gfx targets require gridsize for transpse be under the 65535 limit otherwise we'll error out.
Lipamdhip.so will error out in newer ROCm to warn about this but in previous cases we would get undefined behavior if gridsize was larger than anticipated.