Skip to content

Commit

Permalink
Drop use of f16c instructions (#768)
Browse files Browse the repository at this point in the history
The -mf16c flag is troublesome as those instructions may not be
available on older CPUs. The clang compiler also seems to emit
AVX instructions when it is told that it can use F16C.
The flag can be dropped without consequence as rocSOLVER does not use
half precision.

This was done for rocBLAS in c6bc09073959a2881a701b88ae1ed9de469354f1.
  • Loading branch information
cgmb authored Jul 25, 2024
1 parent 057cfa7 commit df88461
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
4 changes: 1 addition & 3 deletions clients/benchmarks/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ##########################################################################
# Copyright (C) 2016-2023 Advanced Micro Devices, Inc. All rights reserved.
# Copyright (C) 2016-2024 Advanced Micro Devices, Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
Expand Down Expand Up @@ -37,8 +37,6 @@ target_link_libraries(rocsolver-bench PRIVATE
roc::rocsolver
)

# Turn on f16c intrinsics
target_compile_options(rocsolver-bench PRIVATE -mf16c)
target_compile_definitions(rocsolver-bench PRIVATE
ROCM_USE_FLOAT16
ROCSOLVER_CLIENTS_BENCH
Expand Down
2 changes: 0 additions & 2 deletions clients/gtest/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,6 @@ target_link_libraries(rocsolver-test PRIVATE
roc::rocblas
)

# Turn on f16c intrinsics
target_compile_options(rocsolver-test PRIVATE -mf16c)
target_compile_definitions(rocsolver-test PRIVATE
ROCM_USE_FLOAT16
ROCSOLVER_CLIENTS_TEST
Expand Down

0 comments on commit df88461

Please sign in to comment.