Skip to content

Commit

Permalink
Fix synchronization issue in stein (#775)
Browse files Browse the repository at this point in the history
* Fix synchronization issue in stein

* Updated changelog
  • Loading branch information
tfalders authored Aug 1, 2024
1 parent e169341 commit ec88119
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ Full documentation for rocSOLVER is available at the [rocSOLVER documentation](h

### Fixed
- Fixed potential accuracy degradation in SYEVJ/HEEVJ for inputs with small eigenvalues.
- Fixed synchronization issue in STEIN.

### Known Issues
- A known issue in STEBZ can lead to errors in routines based on Bisection to compute eigenvalues for
Expand Down
1 change: 1 addition & 0 deletions library/src/auxiliary/rocauxiliary_stein.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,7 @@ __device__ void run_stein(const int tid,
nrm2<MAX_THDS, S>(tid, blksize, work, 1, sval2);
__syncthreads();
scl = (work[sidx[0] - 1] >= 0 ? S(1) / sval2[0] : S(-1) / sval2[0]);
__syncthreads();
for(i = tid; i < blksize; i += MAX_THDS) // <- scal
work[i] = work[i] * scl;
__syncthreads();
Expand Down

0 comments on commit ec88119

Please sign in to comment.