Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release staging/rocm rel 6.1 to build with libfmt 11.0.1 #764

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+7 −5
Open

Fix release staging/rocm rel 6.1 to build with libfmt 11.0.1 #764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd38229
Drop gfx803 and gfx900 from default build targets (#658)
cgmb Jan 28, 2024
5e2d8d5
Update rocblas_test.hpp to build with libfmt 11.0.1
perestoronin Jul 13, 2024
8dbb63a
Update client.cpp to build with libfmt 11.0.1
perestoronin Jul 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ Full documentation for rocSOLVER is available at [rocsolver.readthedocs.io](http
### Changed
- Relaxed array length requirements for GESVDX with `rocblas_srange_index`.

### Removed
- Removed gfx803 and gfx900 from default build targets.

### Fixed
- Corrected singular vector normalization in BDSVDX and GESVDX
- Fixed potential memory access fault in STEIN, SYEVX/HEEVX, SYGVX/HEGVX, BDSVDX and GESVDX
Expand Down
4 changes: 1 addition & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ##########################################################################
# Copyright (C) 2019-2023 Advanced Micro Devices, Inc. All rights reserved.
# Copyright (C) 2019-2024 Advanced Micro Devices, Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
Expand Down Expand Up @@ -167,8 +167,6 @@ if(NOT DEFINED AMDGPU_TARGETS)
gfx1102
)
set(AMDGPU_TARGETS_INIT
gfx803
gfx900
gfx906:xnack-
gfx908:xnack-
gfx1010
Expand Down
2 changes: 1 addition & 1 deletion clients/benchmarks/client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ try
// print help message
if(vm.count("help"))
{
fmt::print("{}{}\n", help_str, desc);
std::cout << help_str << desc << std::endl;
return 0;
}

Expand Down
3 changes: 2 additions & 1 deletion clients/rocblascommon/rocblas_test.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ inline void rocblas_expect_status(rocblas_status status, rocblas_status expect)
auto error = ERROR; \
if(error != hipSuccess) \
{ \
fmt::print(stderr, "error: {} ({}) at {}:{}\n", hipGetErrorString(error), error, \
fmt::print(stderr, "error: {} ({}) at {}:{}\n", hipGetErrorString(error), \
static_cast<int32_t>(error), \
__FILE__, __LINE__); \
rocblas_abort(); \
} \
Expand Down