Cherry pick tests' fixes (#810) into 6.3 #878
Open
+1,209
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve robustness of SYGVDX/HEGVDX tests * Preliminary changes to sygvdx's error bound computation * Enable hashing output for sygvdx (ROCm#854) * enable hash checking for sygvdx * address feedback * add support for getrf, potrf, syevx, sygvx * amend comments, update sygvdx (cherry picked from commit 38c7a3a) * Update sygvdx test to handle case in which number of eigenvalues differ This commit updates sygvdx's test to allow it to gracefully handle the case in which the number of eigenvalues computed in rocSOLVER differ from the number of reference eigenvalues. * Refactor sygvdx-hegvdx tests This commit updates the error bounds and fixes bugs in the sygvdx-hegvdx tests. It also adds code to allow selecting whether the tests should enforce equality on the number of reference and computed eivenvalues (default is yes); and whether the tests should use new or legacy error bounds (default is to use new error bounds). * Add documentation and small improvements to code * Update comments * Update `clss::print_debug()` method * Make sygvdx-hegvdx tests slightly more strict * Apply clang-format * Implement suggestions and improve comments * Fix typos * Fix typo * Add minor fixes and improvements * Add minor clarifications * Add missing license and update dates on modified files * Address review comments --------- Co-authored-by: Jonah Quist <[email protected]> (cherry picked from commit b94dba0)
jmachado-amd
requested review from
jzuniga-amd,
tfalders,
cgmb,
qjojo and
EdDAzevedo
as code owners
jmachado-amd
added
the
noOptimizations
tfalders
approved these changes
Jan 10, 2025
qjojo
approved these changes
Jan 14, 2025
EdDAzevedo
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the error bounds and fixes bugs in the sygvdx-hegvdx tests. It also adds code to allow selecting whether the tests should enforce equality on the number of reference and computed eivenvalues (default is yes); and whether the tests should use new or legacy error bounds (default is to use new error bounds).
(cherry picked from commit b94dba0)