Updated build from source instructions to resolve issue #259 #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbr ol linux kernel version (#249)
* Update path to the offline installer to add 'rocm-rel-' before '<rocm-version>' text. (#184) * build(deps): Bump sphinx-substitution-extensions in /docs/sphinx (#253) Bumps [sphinx-substitution-extensions](https://github.com/adamtheturtle/sphinx-substitution-extensions) from 2024.2.25 to 2024.8.6. - [Release notes](https://github.com/adamtheturtle/sphinx-substitution-extensions/releases) - [Changelog](https://github.com/adamtheturtle/sphinx-substitution-extensions/blob/main/CHANGELOG.rst) - [Commits](adamtheturtle/sphinx-substitution-extensions@2024.02.25...2024.08.06) --- updated-dependencies: - dependency-name: sphinx-substitution-extensions dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): Bump rocm-docs-core from 1.6.1 to 1.6.2 in /docs/sphinx (#252) Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.6.1 to 1.6.2. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.6.1...v1.6.2) --- updated-dependencies: - dependency-name: rocm-docs-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sam Wu <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: pbhandar-amd <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Looks like I accidentally pulled in some other commits, so I will delete this PR and recreate if needed |
Updated instructions for building the offline installer tool from source: - changed git link from [email protected]:ROCm/rocm-install-on-linux.git to https://github.com/ROCm/rocm-install-on-linux to use HTTPS instead of SSH to pull the code - Adjusted the path in step 3 to include the folder created by `git pull`
missed the "er" at the end of the path `cd rocm-install-on-linux/src/offline-install` -> `cd rocm-install-on-linux/src/offline-installer`
|
Updated PR to remove unrelated commits |
peterjunpark
approved these changes
Aug 9, 2024
dbieleck
approved these changes
Aug 12, 2024
peterjunpark
pushed a commit
to peterjunpark/rocm-install-on-linux
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves issue #259
[email protected]:ROCm/rocm-install-on-linux.gittohttps://github.com/ROCm/rocm-install-on-linuxcd rocm-install-on-linux/src/offline-installer