Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide keras normalization layer in tf #2733

Open
wants to merge 2 commits into
base: develop-upstream
Choose a base branch
from

Conversation

alekstheod
Copy link

Running benchmarks which are based on the old implementation of the tensorflow (1.x) or a compatibility layer was not possible without this change. Batch normalization layer was removed from the latest version of the framework. Instead we use the Batch normalization from the keras api.

@jayfurmanek
Copy link

I think probably the best solution is to update the user code. We could try pushing this upstream though I suspect it wouldn't be accepted.

@alekstheod
Copy link
Author

I think probably the best solution is to update the user code. We could try pushing this upstream though I suspect it wouldn't be accepted.

I am not sure what is the correct fix here. From our perspective the compatibility later will not be working without that change. This change was done just to run our old benchmark project with the newest tf. I will discuss that in our daily and check how to handle that.

@i-chaochen
Copy link

This change was done just to run our old benchmark project with the newest tf.

our old benchmark project? do you mean DLM or something else?

@alekstheod
Copy link
Author

This change was done just to run our old benchmark project with the newest tf.

our old benchmark project? do you mean DLM or something else?

I mean this project: https://github.com/ROCm/benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants