Skip to content

Commit

Permalink
chore: fix some comments (#2588)
Browse files Browse the repository at this point in the history
Signed-off-by: fanqiaojun <[email protected]>
  • Loading branch information
fanqiaojun authored Apr 20, 2024
1 parent b0811e8 commit a590473
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ Thank you for your interest in helping with documentation! Your contributions wi

If you're thinking about adding new operators to RxSwift, please make sure you discuss them via an [issue](https://github.com/ReactiveX/RxSwift/issues) first. RxSwift is a large project, and we're trying to keep its core as compact as possible. We understand the desire to fulfill various kinds of needs, and want to make sure the core serves the majority of developers.

Any operator you need may also be needed by others! But not all operators belong to the RxSwift core. The [RxSwift Commmunity](https://github.com/RxSwiftCommunity/) is home to many projects that may be a better recipient for the improvements you want to bring. In some cases, you may even find that your specific problem is addressed by one of the RxSwiftCommunity project!
Any operator you need may also be needed by others! But not all operators belong to the RxSwift core. The [RxSwift Community](https://github.com/RxSwiftCommunity/) is home to many projects that may be a better recipient for the improvements you want to bring. In some cases, you may even find that your specific problem is addressed by one of the RxSwiftCommunity project!

Some operators, even though available in the core of other ReactiveX implementations, may be left out of the RxSwift code. Some of them can go into the [RxSwiftExt](https://github.com/RxSwiftCommunity/RxSwiftExt) project, others can be hosted in one of the many satellite community projects.

Expand Down
2 changes: 1 addition & 1 deletion Documentation/SwiftConcurrency.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ do {
}
```

Note that the `Observable` must complete, or the the async task will suspend and never resume back to the parent task.
Note that the `Observable` must complete, or the async task will suspend and never resume back to the parent task.

#### Awaiting a non-throwing sequence

Expand Down
2 changes: 1 addition & 1 deletion RxSwift/Observables/RetryWhen.swift
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ final private class RetryWhenSequenceSink<Sequence: Swift.Sequence, Observer: Ob

override func extract(_ observable: Observable<Element>) -> SequenceGenerator? {
// It is important to always return `nil` here because there are side effects in the `run` method
// that are dependant on particular `retryWhen` operator so single operator stack can't be reused in this
// that are dependent on particular `retryWhen` operator so single operator stack can't be reused in this
// case.
return nil
}
Expand Down

0 comments on commit a590473

Please sign in to comment.