-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VisionOS Support #2564
VisionOS Support #2564
Conversation
@freak4pc previously had to revert #2543, due to this:
Sonoma and Xcode 15 are now releases. So this might be a good time now. Or feel free to keep this open until adoption of Sonoma is higher. |
As this is still Open does it mean that visionOS is not yet supported? |
@nighthawk do you know the timeframe for this getting merged? |
I'm not a maintainer of this project, so I can't answer that. @freak4pc might know. FWIW, this is working fine in my usage so far and the changes are relatively straightforward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in merging, I'll try to get a few other fixes in and cut a release in a week or two.
I have a little question about this @nighthawk. I'm sure it's environmental, but just in case... I have updated to RxSwift 6.7.0 but it's not compiling on visionOS. Xcode claims to have 6.7.0 and I see evidence of your changes throughout, but not in Platform.Darwin.swift which is causing the compile issue. I've done the usual; reset package cache, updated to latest, specific version, etc. Am I going mad? UPDATE: I looked a little harder and it hasn't made it to the main branch. |
Darwin is Linux, is it actually trying to compile that file? I had to remove it because it broke Linux / Unix builds |
Seems this is only a waning and not an error, adding it back. |
@notapplicableio Can you test the main branch to let me know if it fixes the issue? |
@freak4pc I just tested the latest main branch and it's compiling for visionOS again. |
Release 6.7.1, thanks both! |
And for me, too. Thank you @freak4pc and @nighthawk :) |
This PR adds support for visionOS to many more things by dropping a bunch of
|| os(visionOS)
over the place.Note of caution: While I'm using this in one app, and it's working fine there now, I have not tested everything that has been enabled here. However, as the visionOS SDK is still in beta that's probably not a big issue.
This fixes #2530, and is related to #2543.