Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a didFailProvisionalNavigation observer. #2620

Conversation

keisukeYamagishi
Copy link

Overview

I am encountering a significant issue as didFailProvisionalNavigation is missing in WKWebView+Rx.

For more details on this function, please refer to the Apple Developer documentation:

webView(_:didFailProvisionalNavigation:withError:)

https://developer.apple.com/documentation/webkit/wknavigationdelegate/1455637-webview

I have added this function and would greatly appreciate it if knowledgeable individuals could review it.

Thank you very much in advance for your assistance.

@freak4pc
Copy link
Member

freak4pc commented Oct 4, 2024

Hey there! I appreciate the addition, but we generally don't want to add more 'bloat' and code for very narrow and specific use cases that aren't very widely asked by the community. This is true for this PR and also #2619, so i'll close them.

If the use case exists for your, I suggest extending locally for your codebase.

Thanks!

@freak4pc freak4pc closed this Oct 4, 2024
@keisukeYamagishi keisukeYamagishi deleted the feature/add-didFailProvisionalNavigation branch November 5, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants