Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REG-1936] Cleanup withinRect logic #369

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[REG-1936] Cleanup withinRect logic #369

merged 1 commit into from
Dec 17, 2024

Conversation

nAmKcAz
Copy link
Collaborator

@nAmKcAz nAmKcAz commented Dec 16, 2024

  • Uses a common response model for CV results in SDK to remove duplicate code
  • Cleans up the CV withinRect algorithm to fix a bug and make it tolerant of 'any' overlap of that region

Find the pull request instructions here

Every reviewer and the owner of the PR should consider these points in their request (feel free to copy this checklist so you can fill it out yourself in the overall PR comment)

  • The code is extensible and backward compatible
  • New public interfaces are extensible and open to backward compatibility in the future
  • If preparing to remove a field in the future (i.e. this PR removes an argument), the argument stays but is no longer functional, and attaches a deprecation warning. A linear task is also created to track this deletion task.
  • Non-critical or potentially modifiable arguments are optional
  • Breaking changes and the approach to handling them have been verified with the team (in the Linear task, design doc, or PR itself)
  • The code is easy to read
  • Unit tests are added for expected and edge cases
  • Integration tests are added for expected and edge cases
  • Functions and classes are documented
  • Migrations for both up and down operations are completed
  • A documentation PR is created and being reviewed for anything in this PR that requires knowledge to use
  • Implications on other dependent code (i.e. sample games and sample bots) is considered, mentioned, and properly handled
  • Style changes and other non-blocking changes are marked as non-blocking from reviewers

@nAmKcAz nAmKcAz marked this pull request as ready for review December 16, 2024 18:32
@nAmKcAz nAmKcAz requested a review from vontell as a code owner December 16, 2024 18:32
@nAmKcAz nAmKcAz merged commit ff05198 into main Dec 17, 2024
2 checks passed
@nAmKcAz nAmKcAz deleted the zack/reg-1936 branch December 17, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants