[REG-2230 Bot Segment List Support + REG-2231 Saving the results] #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ots into tryout-code
|
Approved by other team members that this is fine to merge in and review all at once |
This was referenced Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok so my branch structure to fix things got really messed up... so I started by working off of Zack's branch to support bot segment lists, and then I pulled in my REG-2231 branch to resolve a compilation error caused by the new location of validations in some of these datastructures. The unfortunate result of this, which I should have done differently, is that my adjustments to Zack's patch PR into REG-2230 is now interwined with my REG-2231 changes.
Anyways, this PR brings this small saving results feature and the bot segment list fixes into my original PR, which has already been approved. Zack and I also already discussed these changes so nothing should be a surprise here hopefully... once I merge this into my original branch, we can do a final review of that PR.
The alternative is that we merge the aaron/reg-2230 branch in main first and then this into main, so we don't need to re-review that other PR, but then we have a half-working prototype in main which I want to avoid...
Once this is approved and merged, we can get rid of #374 and #373