[REG-2222] Support creating and editing segments through the dashboard app #376
Conversation
abeizer
changed the title
|
|
||
| public override string ToString() | ||
| { | ||
| StringBuilder sb = new StringBuilder(1000); |
There was a problem hiding this comment.
make this a readonly threadlocal so we avoid re-allocating/gc'ing it
|
|
||
| public override string ToString() | ||
| { | ||
| StringBuilder sb = new StringBuilder(1000); |
There was a problem hiding this comment.
make this a readonly threadlocal so we avoid re-allocating/gc'ing it
|
|
||
| public override string ToString() | ||
| { | ||
| StringBuilder sb = new StringBuilder(1000); |
There was a problem hiding this comment.
make this a readonly threadlocal so we avoid re-allocating/gc'ing it
|
|
||
| public override string ToString() | ||
| { | ||
| StringBuilder sb = new StringBuilder(1000); |
There was a problem hiding this comment.
make this a readonly threadlocal so we avoid re-allocating/gc'ing it
| * Saves a BotSegmentList to a file | ||
| * </summary> | ||
| * <param name="segmentList">The BotSegmentList to save to file</param> | ||
| * <param name="resourcePath">The segment's resourcePath, if it already exists. If null, a new path will be generated for it.</param> |
There was a problem hiding this comment.
should probably update this comment to indicate that the resource path should NOT include the '.json' suffix
| public static void Delete(string resourcePath) | ||
| { | ||
| resourcePath = resourcePath.Replace('\\', '/'); | ||
| if (!resourcePath.StartsWith("Assets/")) |
There was a problem hiding this comment.
This is only valid if running in the editor. In built runtime this should point to persistent data path.
There was a problem hiding this comment.
Deletion isn't allowed during a build right? This should be similar to what we're doing from the overlay currently, just for a segment versus a sequence
There was a problem hiding this comment.
If you create a copy/override of a sequence/segment packaged in the build, it is written to the persistent data path. You CAN delete that override copy.
There is also an existing code path that deletes the prior existing after writing the new one when renaming.
What has been done
resourcePathBotSegmentto facilitate reading + writing segment filesOut of scope
Find the pull request instructions here
Every reviewer and the owner of the PR should consider these points in their request (feel free to copy this checklist so you can fill it out yourself in the overall PR comment)