Refactor/cloud breach s3 #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-aiken
commented
Sep 13, 2023
|
|
||
| } | ||
| #S3 Full Access Policy | ||
| data "aws_iam_policy" "s3-full-access" { |
| "Sid": "" | ||
| Version = "2012-10-17", | ||
| Statement = [ | ||
| { |
|
|
||
| #IAM Role Policy Attachment | ||
| resource "aws_iam_role_policy_attachment" "cg-banking-WAF-Role-policy-attachment-s3" { |
| from_port = 22 | ||
| to_port = 22 | ||
| protocol = "tcp" | ||
| cidr_blocks = var.cg_whitelist | ||
| } |
| subnet_id = aws_subnet.cg-public-subnet-1.id | ||
| associate_public_ip_address = true | ||
|
|
||
| vpc_security_group_ids = [ |
| default_tags = { | ||
| Stack = var.stack-name | ||
| Scenario = var.scenario-name | ||
| } |
There was a problem hiding this comment.
Locals to combine default tags & other variables
| bucket = "${aws_s3_bucket.cg-cardholder-data-bucket.id}" | ||
| key = "cardholder_data_primary.csv" | ||
| source = "../assets/cardholder_data_primary.csv" | ||
| tags = { |
There was a problem hiding this comment.
Update aws_s3_bucket_object -> aws_s3_object
Combined all objects into a single looped resources
| @@ -1,32 +1,53 @@ | |||
| #Required: AWS Profile | |||
| variable "profile" { | |||
There was a problem hiding this comment.
Add type and description
| version = "~> 4.16" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Add minimum TF versions (linting)
| @@ -1,61 +1,63 @@ | |||
| resource "aws_vpc" "cg-vpc" { | |||
jdearmas
reviewed
Nov 5, 2023
| #Required: User's Public IP Address(es) | ||
| variable "cg_whitelist" { | ||
| default = "../whitelist.txt" | ||
| description = "User's public IP address, pulled from the file ../whitelist.txt" | ||
| default = ["0.0.0.0/0"] |
There was a problem hiding this comment.
We could switch this to something else (0.0.0.0/32) Its more to switch to a default value that would be valid (list(string))
jdearmas
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of Changes
terraform fmtTesting
Tested with version
1.2.0&1.5.6of Terraform