Updated Dockerfile and requirements.txt #291
Conversation
|
@galoget can you provide the command that produced the errors in the screenshot?
|
|
@nobodynate yeah sure, this is the command: docker build -t cloudgoat:2.0.0 .I executed it on a Debian-based OS as mentioned before. The build process will succeed but in the output you will find those errors related with Python dependencies. Meaning that even after creating the image, you won't have a proper installed environment.
|
requirements.txt
Outdated
| @@ -2,8 +2,8 @@ | |||
| # black==19.3b0 | |||
There was a problem hiding this comment.
Could you also update is requirements.txt with the new versions
There was a problem hiding this comment.
OK, I will update the dev requirements.
There was a problem hiding this comment.
Done, also updated the Python version in the Dockerfile as Python 3.8 has reached its end of life (EOL) as of October 7, 2024.
References:
|
|
||
| LABEL maintainer="Rhino Assessment Team <[email protected]>" | ||
| LABEL cloudgoat.version="2.0.0" | ||
|
|
||
| RUN apk add --no-cache --update bash bash-completion docker-bash-completion openssh curl | ||
|
|
||
| # Install Terraform and AWS CLI | ||
| RUN wget -O terraform.zip 'https://releases.hashicorp.com/terraform/1.3.9/terraform_1.3.9_linux_arm64.zip' \ | ||
| RUN wget -O terraform.zip 'https://releases.hashicorp.com/terraform/1.10.0/terraform_1.10.0_linux_arm64.zip' \ |
There was a problem hiding this comment.
We should make sure that 1.10 is backwards compatible with all scenarios.
It looks like 0.14 is what everything "should" support.
I think we should probably increase the minimum TF version (@nobodynate)
There was a problem hiding this comment.
Based on what I searched, Terraform v1.10 honors the Terraform v1.0 Compatibility Promises.
References:
There was a problem hiding this comment.
I can also update the TF version in the README.md if you agree.
…ibraries in requirements.txt
|
Could we switch to using |
Overview of Changes
The current Dockerfile was not working as is anymore (tested on Kali Linux 2024.4), it always showed this error message during the building process.
So, I updated the files to fix dependency issues.
Testing
I tested it and it works fine after my changes.
I did not change the files to the latest version of the software in order to avoid having any bugs, so, I chose some versions that are more recent, have security fixes and are stable enough.