Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed incorrect damping calculation in shocks3 #3229

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Removed incorrect damping calculation in shocks3 #3229

wants to merge 1 commit into from

Conversation

danmackey
Copy link
Contributor

Fixes #3228

@ohlidalp
Copy link
Member

Thanks for the research!
The code in question was introduced here: 833f2c9 (shortly after initial 'shocks3' 867ff45)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shocks3 damping calculation is wrong?
2 participants
@danmackey @ohlidalp