🚚 Added videocamera role MIRROR_NOFLIP (2)
#3235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohlidalp
force-pushed
the
3153_graysonk95_mirrors_flipped
branch
from
6bb82d8 to
d94b097
Compare
Same as `MIRROR` (1), but without flipping the texture horizontally (expects texcoords to be already flipped in the mesh) Additional Codechanges: * To make naming consistent, enum VideoCamType was renamed to VideoCamRole and moved to Application.h so that both RigDef fileformat and GfxActor can easily #include it. * The rigdef (truck) parser now uses the enum instead of numeric constant. This simplifies the spawner as it just copies the value.
ohlidalp
force-pushed
the
3153_graysonk95_mirrors_flipped
branch
from
d94b097 to
734b321
Compare
also changed int->size_t in GUI_VehicleInfoTPanel.cpp
|
|
The full `addonpart_tweak_videocamera` mechanism wasn't implemented, only the UI override.
ohlidalp
force-pushed
the
3153_graysonk95_mirrors_flipped
branch
from
10fd073 to
2417275
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3137
Same as
MIRROR(1), but without flipping the texture horizontally (expects texcoords to be already flipped in the mesh). For more info see https://docs.rigsofrods.org/vehicle-creation/fileformat-truck/#videocameraI haven't coded the Tuning menu control yet, I can add it if it's deemed necessary.UPDATE: done, see below.EDIT:
converted to draft because it's not working as expected if the mirror is actually a tracking videocamera (the lookat node is set).EDIT2: Fixed, ready for review.