Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ament_python to build packages rather than ament_cmake #939

Open
wants to merge 38 commits into
base: ros2
Choose a base branch
from
Open

Use ament_python to build packages rather than ament_cmake #939

wants to merge 38 commits into from

Commits on Jul 16, 2024

  1. Changed type hints in ros_loader.py to use imports from Typing, resto… 

    …ring compatibility with Python <3.9.
    @EricGallimore
    EricGallimore committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7bdecc1 View commit details
    Browse the repository at this point in the history

  2. Reordered imports alphabetically to fix isort linting CI error.

    @EricGallimore
    EricGallimore committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    3f44e5f View commit details
    Browse the repository at this point in the history

  3. Change rosapi package to use ament_python rather than ament_cmake.

    @EricGallimore
    EricGallimore committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    8b1b597 View commit details
    Browse the repository at this point in the history

  4. Change rosbridge_server to use ament_python rather than ament_cmake.

    @EricGallimore
    EricGallimore committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e3f823e View commit details
    Browse the repository at this point in the history

  5. Fix setup.py formatting.

    @EricGallimore
    EricGallimore committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    81b6172 View commit details
    Browse the repository at this point in the history

  6. Run pre-commit and commit fixes. (Not sure why this is needed, since … 

    …some of these files aren't touched in this branch.)
    @EricGallimore
    EricGallimore committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a6d28c6 View commit details
    Browse the repository at this point in the history

  7. Revert inadvertent changes to rosbridge_websocket symlink.

    @EricGallimore
    EricGallimore committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    75ec314 View commit details
    Browse the repository at this point in the history

  8. Merge branch '937-type-string-dependency' into ament_python

    @EricGallimore
    EricGallimore committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    377b9b7 View commit details
    Browse the repository at this point in the history

  9. Fix launch files in rosbridge_server.

    @EricGallimore
    EricGallimore committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    609e037 View commit details
    Browse the repository at this point in the history

  10. Fix setup.cfg paths.

    @EricGallimore
    EricGallimore committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    f7b258e View commit details
    Browse the repository at this point in the history

  11. Fix setup.py data_files.

    @EricGallimore
    EricGallimore committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    88534ab View commit details
    Browse the repository at this point in the history

  12. Moved rosapi_node and rosbridge_websocket.py into respective packages.

    @EricGallimore
    EricGallimore committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    1617efc View commit details
    Browse the repository at this point in the history

  13. Add resource files.

    @EricGallimore
    EricGallimore committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    b808d1a View commit details
    Browse the repository at this point in the history

  14. Reorganize package to follow ROS2 python convention (and resolve issu… 

    …e with find_packages)
    @EricGallimore
    EricGallimore committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    1876681 View commit details
    Browse the repository at this point in the history

  15. Run pre-commit and fix linting errors.

    @EricGallimore
    EricGallimore committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    24317fc View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Merge branch 'ros2' into ament_python

    @sea-bass
    sea-bass authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    3d81ba8 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. rosapi: Don't start parameter services that aren't spun (RobotWebTool… 

    …s#943) (RobotWebTools#944)
    @bmartin427
    bmartin427 authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    974c6b7 View commit details
    Browse the repository at this point in the history

  2. rosbridge_websocket: Stop websocket server if ROS shuts down (RobotWe… 

    …bTools#945) (RobotWebTools#946)

Signed-off-by: Brad Martin <[email protected]>
    @bmartin427
    bmartin427 authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    8b0b4c5 View commit details
    Browse the repository at this point in the history

  3. Avoid stale subscription when unsubscribing during resubscription (Ro… 

    …botWebTools#947) (RobotWebTools#948)

If a client asks to subscribe to the same topic more than once, then disconnects, only a
pending 'new' subscription may get deleted, leaving the 'old' subscription active
indefinitely.

Signed-off-by: Brad Martin <[email protected]>
    @bmartin427
    bmartin427 authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    baa463a View commit details
    Browse the repository at this point in the history

  4. docs: update ROSBRIDGE_PROTOCOL.md - correcting indentation (RobotWeb… 

    …Tools#949)

Add whitespace in front of all ROS action operations -- for correct indentation in Markdown
    @ManuETR
    ManuETR authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    996fddd View commit details
    Browse the repository at this point in the history

  5. fix: update new subs with dds from publisher (RobotWebTools#940)

    @dnikitop
    dnikitop authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    febe1c4 View commit details
    Browse the repository at this point in the history

  6. Fixed executable bit on scripts.

    @EricGallimore
    EricGallimore committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    677dcae View commit details
    Browse the repository at this point in the history

  7. Merge branch 'ament_python' of https://github.com/EricGallimore/rosbr… 

    …idge_suite into ament_python
    @EricGallimore
    EricGallimore committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    04aa0d4 View commit details
    Browse the repository at this point in the history

  8. Fix length-limited list types (RobotWebTools#840)

    @EzraBrooks
    EzraBrooks authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    55b8fa3 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Change rosapi package to use ament_python rather than ament_cmake.

    @EricGallimore
    EricGallimore committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f7aa27a View commit details
    Browse the repository at this point in the history

  2. Change rosbridge_server to use ament_python rather than ament_cmake.

    @EricGallimore
    EricGallimore committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    28eb1c0 View commit details
    Browse the repository at this point in the history

  3. Fix setup.py formatting.

    @EricGallimore
    EricGallimore committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ad1aa25 View commit details
    Browse the repository at this point in the history

  4. Run pre-commit and commit fixes. (Not sure why this is needed, since … 

    …some of these files aren't touched in this branch.)
    @EricGallimore
    EricGallimore committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    98b4347 View commit details
    Browse the repository at this point in the history

  5. Revert inadvertent changes to rosbridge_websocket symlink.

    @EricGallimore
    EricGallimore committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    b9d200d View commit details
    Browse the repository at this point in the history

  6. Fix launch files in rosbridge_server.

    @EricGallimore
    EricGallimore committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    889b229 View commit details
    Browse the repository at this point in the history

  7. Fix setup.cfg paths.

    @EricGallimore
    EricGallimore committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    2882d8e View commit details
    Browse the repository at this point in the history

  8. Fix setup.py data_files.

    @EricGallimore
    EricGallimore committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    407af90 View commit details
    Browse the repository at this point in the history

  9. Moved rosapi_node and rosbridge_websocket.py into respective packages.

    @EricGallimore
    EricGallimore committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ce4d937 View commit details
    Browse the repository at this point in the history

  10. Add resource files.

    @EricGallimore
    EricGallimore committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    cc00596 View commit details
    Browse the repository at this point in the history

  11. Reorganize package to follow ROS2 python convention (and resolve issu… 

    …e with find_packages)
    @EricGallimore
    EricGallimore committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    0cc24db View commit details
    Browse the repository at this point in the history

  12. Run pre-commit and fix linting errors.

    @EricGallimore
    EricGallimore committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f017bd7 View commit details
    Browse the repository at this point in the history

  13. Fixed executable bit on scripts.

    @EricGallimore
    EricGallimore committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8a72cc6 View commit details
    Browse the repository at this point in the history

  14. Merge remote-tracking branch 'origin/ament_python' into ament_python

    @EricGallimore
    EricGallimore committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    496dde3 View commit details
    Browse the repository at this point in the history