First release #1

jannatkhandev · 2025-01-07T11:22:22Z

A fully functional end-to-end test RC app for Todoist integration.
closes RocketChat/Rocket.Chat#34896

🚀 Looking forward to add many more features.

Screen.Recording.2025-01-07.at.5.1.mp4

Todoist App provides you the following slash commands, /todoist:

help: shows this list.
auth: starts the process to authorize your Todoist Account.
task: opens modal to create a new task.
projects: fetches the projects you are part of.
tasks: fetches the active tasks.
sections: fetches the active tasks.
labels: fetches your personal labels.
shared-labels: fetches your shared labels.

Allows users to create tasks from message, create task within project.

jannatkhandev · 2025-01-07T12:18:51Z

@casalsgh sorry to tag you, but this is ready to merge.
Please take a look.
Best,
Jannat.

Gustrb · 2025-01-13T11:33:50Z

Hey, @jannatkhandev just to make you aware, this is a 4k+ line pull request, the review will take more time than it would be since, I can't look at this PR in my free time. So I'll have to check if it makes sense with the rest of the company for me to help you through it.
But don't worry, I didn't forgot about you :)

Gustrb

I couldn't review everything, but since the code is mostly similar, I think you'll be able to extrapolate a lot of those comments to more places

README.md

TodoistApp.ts

src/commands/subcommands/authorize.ts

src/commands/subcommands/labels.ts

jannatkhandev · 2025-01-13T13:53:54Z

Thanks for the detailed feedback, I will ensure I inspect rest of the code as well.
I really appreciate your time.
Best,
Jannat.

jannatkhandev · 2025-01-16T12:00:08Z

Hey there,
I have made changes as per the review, please take a look.

TodoistApp.ts

src/commands/subcommands/labels.ts

src/handlers/viewSubmitInteraction.ts

src/helpers/const.ts

src/helpers/message.ts

src/helpers/notification.ts

src/lib/create/createTask.ts

src/lib/delete/deleteItem.ts

src/lib/share/shareComment.ts

src/lib/share/shareItem.ts

jannatkhandev · 2025-01-16T14:26:50Z

Thanks for the detailed feedback. I have addressed the review and have made changes accordingly.
Also have tested my app end to end.

jannatkhandev · 2025-01-16T14:27:12Z

Thanks for the detailed feedback. I have addressed the review and have made changes accordingly. Also have tested my app end to end.

I really appreciate your time, I shall be highly grateful to you :)

src/commands/subcommands/authorize.ts

src/commands/subcommands/labels.ts

Gustrb · 2025-01-17T17:08:53Z

src/commands/subcommands/labels.ts

+async function createLabelSection(label: ILabel): Promise<LayoutBlock[]> {
+  const labelNameBlock = getSectionBlock(label.name);
+  const labelContextBlock = getContextBlock(
+    `Color: ${String(label.color).charAt(0).toUpperCase() + String(label.color).slice(1)} | ` +


Lets put this into a separate function wdyt?
this function is dealing contextually with label blocks, I don't think it is good for it to know exactly how the color field is internally

src/commands/subcommands/labels.ts

src/commands/subcommands/projects.ts

src/lib/delete/deleteItem.ts

src/lib/fetch/fetchComments.ts

src/lib/share/shareItem.ts

Gustrb · 2025-01-17T17:47:50Z

Ok so, I took some time to look at your code, and it is getting pretty good, congratulations 🚀
But I have A few issues I found during the review.
Most of them are due to:

Poor logging (you'll thank me later for being annoying with this, logging is our friend when everything stops working)
No domaing splitting (you are grouping functions by "what they do" instead of by "what they are"), doing that will make the code easier to read and navigate
Mixing up what is domain and what is infraestructure, please, avoid doing direct HTTP calls from your UI components, where you build your UI should not care about HTTP stuff such as the error that came back, or if the body is empty. When you start defering that to a service class, it will become clear there are a few issues with how everything is being handled, so the first issue is:

There are not a lot of validations on what we are sending the network (nothing on the typesystem): Since our HTTP calls go through a bridge, then through (possibliy) a proxy to get over to the Todoist backend, it might be really slow, so we must be pedantic and only allow http calls that are going to succeed.
There are no validations on the recieving end, everything is being typed as any and then being typed accordingly through a type assertion, this is really dangerous, since we have no idea when the api changes, and small things might start breaking slowly as the time goes by, and we will have 0 visibility into it. So please, use a library to validate your json schema from the response (and type it accordingly in the typesystem, so it is easier to mantain, and one needn't to have the API docs open to change simple stuff in the code)

Gustrb · 2025-01-17T18:09:03Z

Also, dropping here a cool article about defensive programming, I think you'll benefit a lot from thinking like this: https://medium.com/@arumukherjee121/the-art-of-defensive-programming-62c6f22b2758

Since it is really annoying to update apps, and manage your deployed apps, we need to get the first version as stable as possible, and we do it, by programming defensively

jannatkhandev · 2025-01-17T18:28:13Z

I really appreciate your time, the feedback and review really helps me grow as a developer.
As I am still learning and trying to improve, your review really made me understand industry standards.

I will make all the improvements over the weekend and will get ready by Monday addressing all the comments.

Yet again, thanks for your time and feedback.
Best,
Jannat :)

Gustrb · 2025-01-17T18:42:09Z

Don't worry, I'm happy to help :)
I still haven't started doing actual testing, but after this next round of reviews we can start doing this.
You're doing a great job, keep going 🚀

Also, don't worry about being quick to ship stuff, take your time, ponder on your code, experiment, change stuff, that is really important for your growth as a developer.
Have a good weekend!

CLAassistant · 2025-01-24T13:46:19Z

All committers have signed the CLA.

jannatkhandev · 2025-01-24T14:07:36Z

Hello sir,

I deeply retrospected the code and made all requested changes, made the app more robust and code easy to follow.
Please take look.

(Also sorry for messing up the commits, I changed my machine [now I run VPS on a server and use it in VSCode via SSH])

Gustrb · 2025-01-30T10:55:57Z

TodoistApp.ts

+    };
+
+    constructor(info: IAppInfo, logger: ILogger, accessors: IAppAccessors) {
+        super(info, logger, accessors);


why not just:

this.labelService = new LabelService(this);
...

If I call the constructor here it goes into a cyclic loop of invocations as we use TodoistApp in the constructor of each service, hence.

Gustrb · 2025-01-30T11:05:50Z

Looking nice, I just think your validations are a little to optimistic, besides that, the code is looking good, congrats!

First release

6d54d23

jannatkhandev mentioned this pull request Jan 7, 2025

Missing Todoist integration RocketChat/Rocket.Chat#34896

Open

Gustrb suggested changes Jan 13, 2025

View reviewed changes