Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added 'Cancel Recording' and 'Finish Recording' tooltips for audio and video recording buttons. #812

Conversation

dhairyashiil
Copy link
Contributor

Brief Title

Feat: Add 'Cancel Recording' and 'Finish Recording' tooltips for audio and video recording buttons.

Acceptance Criteria fulfillment

  • When the user hovers the mouse over the circle-cross button while recording audio or video, the text "Cancel Recording" should be displayed.
  • When the user hovers the mouse over the circle-check button while recording audio or video, the text "Finish Recording" should be displayed.

Fixes #811

Video/Screenshots:

tooltip.for.audio.video.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-812 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory Spiral-Memory merged commit 9d84f49 into RocketChat:develop Jan 27, 2025
3 checks passed
@Spiral-Memory Spiral-Memory added the chore a subtle fix label Jan 27, 2025
abirc8010 pushed a commit to abirc8010/EmbeddedChat that referenced this pull request Jan 27, 2025
@Spiral-Memory Spiral-Memory changed the title Feat: Added 'Cancel Recording' and 'Finish Recording' tooltips for audio and video recording buttons. chore: Added 'Cancel Recording' and 'Finish Recording' tooltips for audio and video recording buttons. Jan 30, 2025
Spiral-Memory pushed a commit that referenced this pull request Jan 30, 2025
* Fix chatFormatter Toolbar UI

* make message box and popover menu occupy full width

* make message composer configurable

* zIndex fix

* resolve conflict

* Place popoverMenu icon to the extreme right

* feat: Add 'Cancel Recording' and 'Finish Recording' tooltips for audio/video buttons (#812)

* fix message box width and minor UI issues for chatinput formatters

* remove redundant tooltip

* remove audio from pop over menu

* run prettier

* fix audio issue

* change font size for chat input

---------

Co-authored-by: Dhairyashil Shinde <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a subtle fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Add 'Cancel Recording' and 'Finish Recording' tooltips for audio and video recording buttons.
2 participants