Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore : Add Hover Effect to FileMessage Component #845

Merged
merged 4 commits into from
Jan 27, 2025
Merged

chore : Add Hover Effect to FileMessage Component #845

merged 4 commits into from
Jan 27, 2025

Conversation

AyushKumar123456789
Copy link
Contributor

@AyushKumar123456789 AyushKumar123456789 commented Jan 9, 2025 •
edited by Spiral-Memory
Loading

Brief Title

Add Hover Effect to FileMessage Component

Acceptance Criteria fulfillment

  • Added hover styles to the FileMessage component to change the background color on hover, enhancing visual feedback for users.
  • Configured the hover effect to adapt based on the current theme (light or dark), ensuring consistency with the application's overall design.
  • Verified that the addition of the hover effect does not interfere with existing functionalities of the FileMessage component, such as displaying file previews and metrics.

Fixes #844

Video/Screenshots

Added.Hover.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-845 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

Spiral-Memory
Spiral-Memory approved these changes Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@Spiral-Memory Spiral-Memory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spiral-Memory Spiral-Memory merged commit dd4195a into RocketChat:develop Jan 27, 2025
3 checks passed
github-actions bot added a commit that referenced this pull request Jan 27, 2025
@github-actions
Remove deployment for PR #845
260d808
@Spiral-Memory Spiral-Memory changed the title fix : Add Hover Effect to FileMessage Component chore : Add Hover Effect to FileMessage Component Jan 30, 2025
@Spiral-Memory Spiral-Memory added the chore a subtle fix label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spiral-Memory Spiral-Memory Spiral-Memory approved these changes

Assignees
No one assigned
Labels
chore a subtle fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug : File Gallery lacks hover effect.
2 participants
@AyushKumar123456789 @Spiral-Memory