-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: highlight search messages #884
base: develop
Are you sure you want to change the base?
Feat: highlight search messages #884
Conversation
2ef2985
to
8f3bb40
Compare
@@ -81,6 +81,13 @@ export const EmojiStyles = { | |||
`, | |||
}; | |||
|
|||
export const useHighlightTextStyles = { | |||
highlight: css` | |||
background-color: yellow; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use hardcoded colors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, sorry about this. I forgot to set the color according to the mode and theme.
This is a great PR. I think, you can optimize it further, Look into it, if you can reduce the amount of changes for this Thanks |
Thank you for the appreciation. I'm happy you liked it 😁, and yes, I will look into how I can optimize it further |
Brief Title
Highlight searched message text in rendered messages in Sidebar
Acceptance Criteria fulfillment
Fixes #883
Video/Screenshots:
highlight.searched.messages.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-884 after approval. Contributors are requested to replace
<pr_number>
with the actual PR number.