Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Message & Chat Input UI Enhancement for Edit Message Functionality #898

Conversation

dhairyashiil
Copy link
Contributor

Brief Title

Feat: Message & Chat Input UI Enhancement for Edit Message Functionality

Acceptance Criteria fulfillment

  • When a message is clicked to be edited, its background color changes dynamically to indicate it is being edited.
  • The background color of the chat input box matches the edited message's background color.
  • The implementation dynamically handles light and dark themes, ensuring appropriate color contrast for both.
  • Ensure smooth transition between color changes for both message and chat input box.

Fixes #897

Video/Screenshots

light.theme.edit.message.mp4

and

dark.theme.edit.message.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-898 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory
Copy link
Collaborator

I didn't really like this, that's why i removed it and had subtle background change if you notice. I think we are good here for now.

@dhairyashiil
Copy link
Contributor Author

I didn't really like this, that's why i removed it and had subtle background change if you notice. I think we are good here for now.

Yes, I agree that it doesn't look that good in a dark theme, but for the light theme, I think it looks good. Can we consider this config only for the light theme?

@dhairyashiil
Copy link
Contributor Author

What if we configured a more subtle color for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Message & Chat Input UI Enhancement for Edit Message Functionality
2 participants