Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added search instruction to Search Messages sidebar #910

Conversation

dhairyashiil
Copy link
Contributor

Brief Title

Added search instruction to Search Messages sidebar

Acceptance Criteria fulfillment

  • Instruction Display: When the view type is "Search Messages", a section with a markdown formatted message appears at the top of the sidebar.
  • Styling: The instruction should have its own custom style handling dark and light themes.
  • Rendering Condition: The instruction should only be rendered when the title of the view is Search Messages.

Fixes #909

Video/Screenshots

image

and

image

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-910 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory
Copy link
Collaborator

Hi @dhairyashiil
I don't really see it adds any value, the current one feels sufficient to me

@dhairyashiil
Copy link
Contributor Author

Hello @Spiral-Memory ,

Because this instruction was present in RC, I learned about this concept. By using the regular expression search method, we can find the required message even when we don’t know the exact content.

By using only /mory/i, we can find the word Spiral-Memory.

image

I didn’t know this search feature was available in RC until I saw the same instruction there. Also, you’ll notice that it’s already implemented in Embedded Chat, but if we haven’t informed the user about this feature, how will they know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Add Search Instruction on Search Messages Sidebar
2 participants