Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix counts, Don't show occurrences from other projects #359

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

mihow
Copy link
Collaborator

@mihow mihow commented Feb 20, 2024

No description provided.

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit f08a2cb
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/65d4678843967e00085f18e5
😎 Deploy Preview https://deploy-preview-359--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for ami-web ready!

Name Link
🔨 Latest commit f08a2cb
🔍 Latest deploy log https://app.netlify.com/sites/ami-web/deploys/65d46788dcf1dd000883ddbb
😎 Deploy Preview https://deploy-preview-359--ami-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 69
Accessibility: 95
Best Practices: 92
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@mihow
Copy link
Collaborator Author

mihow commented Feb 20, 2024

@annavik this includes two frontend fixes that could be nicer. We need to pass the project id to the API request in a species detail modal so it only shows occurrences from the correct project. Also the date & time links were broken, but I believe passing the timestamp to get the capturePageOffset is working!

@mihow mihow merged commit a355c8c into main Feb 20, 2024
6 checks passed
@mihow mihow deleted the fix/species-from-other-projects branch February 20, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant