You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realized after checking #375 that how we format the frontend code is perhaps not super clear. In this PR we update the README and also we include a format check in the GitHub workflow. The commit history in this PR shows how the format check is first failing, then successful after code is auto formatted.
Thanks @annavik! My formatter in VSCode was fighting with the existing formatting. I pushed two commits to enforce eslint & prettier on-save & pre-commit (then you don't have to wait for the github workflow to reject the changes to know something is wrong). Will you review the settings in .vscode/settings.json and the recommended extensions in .vscode/extensions.json? I like to have shared settings for the project workspace so everyone shares the same formatting during development. I just took a guess at the typescript settings. VS Code recently changed somethings in regards to formatting & linting extensions and I don't totally understand the new approach, but I believe this settings file uses the latest style now.
Thanks @annavik! My formatter in VSCode was fighting with the existing formatting. I pushed two commits to enforce eslint & prettier on-save & pre-commit (then you don't have to wait for the github workflow to reject the changes to know something is wrong). Will you review the settings in .vscode/settings.json and the recommended extensions in .vscode/extensions.json? I like to have shared settings for the project workspace so everyone shares the same formatting during development. I just took a guess at the typescript settings. VS Code recently changed somethings in regards to formatting & linting extensions and I don't totally understand the new approach, but I believe this settings file uses the latest style now.
Ah yes! Thanks for updating the VSCode recommendations and settings, looks perfect to me!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
annavik
force-pushed
the
improvement/check-formatting
branch
from
I realized after checking #375 that how we format the frontend code is perhaps not super clear. In this PR we update the README and also we include a format check in the GitHub workflow. The commit history in this PR shows how the format check is first failing, then successful after code is auto formatted.