Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small tweaks to deployment location #422

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Small tweaks to deployment location #422

merged 4 commits into from
Jun 14, 2024

Conversation

annavik
Copy link
Member

@annavik annavik commented Jun 12, 2024

Small deployment location tweaks after feedback from Lars!

Summary of changes:

  • Update step size for deployment latitude/longitude fields from 1 -> 0.00001.
  • Hide step arrows for deployment latitude/longitude fields. Most common use case here is probably to copy/paste values, not use arrows. However, stepping will still be possible to do from keyboard, no need to override the browser default behaviour here.
  • Enable scroll wheel zoom in all maps
  • Fix missing decimals in latitude/longitude display values (see screenshots)

Before:
Skärmavbild 2024-06-12 kl  16 23 33

After:
Skärmavbild 2024-06-12 kl  16 18 09

@annavik annavik requested a review from mihow June 12, 2024 07:50
Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for ami-web ready!

Name Link
🔨 Latest commit da1389f
🔍 Latest deploy log https://app.netlify.com/sites/ami-web/deploys/6669aeffc42d8600089d4eb6
😎 Deploy Preview https://deploy-preview-422--ami-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 73
Accessibility: 95
Best Practices: 92
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit da1389f
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/6669aeff7410bb0008f88eff
😎 Deploy Preview https://deploy-preview-422--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@annavik annavik changed the title Fix coordinate step size Small tweaks to deployment location Jun 12, 2024
@mihow mihow merged commit 5e65de2 into main Jun 14, 2024
6 checks passed
@mihow mihow deleted the fix/coordinate-step-size branch June 14, 2024 00:28
@annavik annavik added this to the Internal Beta V2 Release milestone Jun 17, 2024
@annavik annavik self-assigned this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants