Fix update password form #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ami-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mihow
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some testing around our password features (to make sure we can bring on new users without too much assistance), and discovered submitting the update password form was not working as expected.
The problem was a nested form situation appeared after the fix in #642. Sorry I missed this before! The user info dialog requires a bit special handling, since we want to present it visually as a form with a small sub form. However nested forms is not valid HTML.
In this PR we fix this problem. Also we include some small style tweaks while we're on it.
After updates: