Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/reprocessing existing results #719

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mihow
Copy link
Collaborator

@mihow mihow commented Feb 6, 2025

Partial fixes for #718

Existing tests are passing now, but in practice images are still being reprocessed and adding duplicate classifications to existing detections.

TODO:

  • add a new test that can reproduce this bug
  • don't add duplicate classifications even if images are reprocessed
  • update ML backend to handle skips on its own

@mihow mihow self-assigned this Feb 6, 2025
Copy link

sentry-io bot commented Feb 6, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: ami/ml/models/pipeline.py

Function Unhandled Issue
collect_images ValueError: Must specify a collection, deployment or a list of images a...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for ami-dev canceled.

Name Link
🔨 Latest commit a6435dd
🔍 Latest deploy log https://app.netlify.com/sites/ami-dev/deploys/67a4710f27fd240008fa1235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant