Fix: Flow is not released when embedded in UINavigationController #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mgray88 here is another one as well. |
mashe
force-pushed
the
fix/flow-is-not-released-when-embedded-in-UINavigationController
branch
from
f3e9a2b to
5991f66
Compare
…NavigationController
mgray88
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR fixes #197
By updating
rxDismissedforUIViewControllerto emit an event whenUIViewControlleris dismissed along with presentingUINavigationController.I could not find a way to replicate dismissal in
XCUnitTests, that is why there are no tests added.Checklist