Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for BINTEXT and BOOLEAN #254

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Added support for BINTEXT and BOOLEAN #254

wants to merge 7 commits into from

Conversation

he-is-harry
Copy link
Contributor

  • Added support for BINTEXT and BOOLEAN for data format version 7
    • BINTEXT is sent and received as buffers
    • BOOLEAN can be sent as strings, numbers, and boolean and received as boolean
  • Modified data type integration tests to skip tests when the data format version is lower than required
  • Added integration tests for BINTEXT and BOOLEAN
  • Added unit tests for BOOLEAN

@he-is-harry
Added support for BINTEXT and BOOLEAN
20bb90d 
- Added support for BINTEXT and BOOLEAN for data format version 7
    - BINTEXT is sent and received as buffers
    - BOOLEAN can be sent as strings, numbers, and boolean and received as boolean
- Modified data type integration tests to skip tests when the data format version is lower than required
- Added integration tests for BINTEXT and BOOLEAN
- Added unit tests for BOOLEAN
@he-is-harry
Added spatialTypes connect option
f83394d 
- Added spatialTypes option to allow strings to be sent for spatial types
    - With spatialTypes=0 (default), strings inputted for ST_GEOMETRY and ST_POINT are interpreted as hex
    - With spatialTypes=1, strings inputted for ST_GEOMETRY and ST_POINT can be encoded in utf8 or cesu8
    - Buffers can be sent in any of these options and will be interpreted as binary
- Added integration tests to check inserting and fetching large ST_GEOMETRY data
- Added some integration tests to check the spatialTypes=1 behaviour
@he-is-harry
Updated ST_GEOMETRY error message
578a745 
- Changed the Writer to return an error message of 'Argument must be a string or Buffer' when an invalid type is entered for spatial types
- Added some hex string and buffer inputs to ST_POINT tests
- Changed some inputs for integration tests to describe what is tested more accurately
@he-is-harry
Merge branch 'spatialTypesOption' into binTextSupport
6e7e6bb 
- Merge changes for data format version 5 into this branch to resolve merge conflicts
@he-is-harry
Merge branch 'master' into binTextSupport
5dd8349
@he-is-harry
Added string input for BINTEXT
d6a27e3 
- Added support for BINTEXT to be entered as a string
    - As a consequence, strings can be inputted for all BLOB types (consistent with hana-client)
- Added normalized typecode for BINTEXT
- Updated data type integration tests to automatically add a ID column to all tables. Now,
  expected outputs will be in the same order as input
@he-is-harry
Changed BINTEXT to be treated as NCLOB
e3353a6 
- Updated the NormalizedTypeCode of BINTEXT so that all inputs to BINTEXT are treated as NCLOB's
    - NCLOB input will be validated on HANA so that the buffer input is valid CESU8
- Added an integration test to check that invalid inputs to BINTEXT will cause an error to be sent back
    - Since the error validation for each argument is done one at a time, and the character validation
is on the server, the test does take longer than 2 seconds to run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@he-is-harry