Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #126 #169

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix for issue #126 #169

wants to merge 2 commits into from

Conversation

Spcemarine
Copy link

Grids attached to grids with a beacon should no longer be deleted while
performing "/delete all nobeacon"

Grids attached to grids with a beacon should no longer be deleted while
performing "/delete all nobeacon"
@ghost
Copy link

ghost commented Oct 3, 2014

While this looks like a good commit, you need to go back and fix the whitespace.

https://github.com/SEModCommunity/SE-Community-Mod-API/wiki/Coding-Standard-reference

Whitespace/Indentation

Code indentation should be done with tabs, NOT spaces. This is to prevent Git conflicts due to inconsistent whitespace characters or newlines. Most client-side merge utilities can handle this but the diff/merge tool built into Github cannot.

@Spcemarine
Copy link
Author

Wooops... since this was a part of one of my plugins I compleatly forgot there were spaces and not tabs when I pasted it. It is fixed now.

@generalwrex
Copy link
Contributor

I don't think pull requests for the 'dev' branch will be accepted at this time, maybe in the future :)

Hang onto it in case we change the layout of the release system!

@Spcemarine
Copy link
Author

I have no idea of your release system... I could make another pull request for the master branch if that helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants