Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed acknowledged rules #1679

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Fixed acknowledged rules #1679

merged 4 commits into from
Feb 7, 2025

Conversation

babakamyljanovssw
Copy link
Member

@babakamyljanovssw babakamyljanovssw commented Feb 4, 2025

cc: @Freego1783

Email: "Re: SSW Rules - Searching by author - Nothing showing for me"

Rules weren't being displayed for Hugo on search page. The reason is when rule is created, the markdown file name was "rules.md", and then it was changed to "rule.md". Current logic for that page only removes "rule.md" from path and it doesn't work for "rules.md".

So I've created function that retrieves path without filename.

image
Figure: Hugo's rule is displayed on Acknowledged section

@babakamyljanovssw babakamyljanovssw changed the title Draft - Fix acknowledgements Fixed acknowledged rules Feb 5, 2025
bradystroud
bradystroud previously approved these changes Feb 5, 2025
@babakamyljanovssw babakamyljanovssw merged commit 539d3f1 into main Feb 7, 2025
5 checks passed
@babakamyljanovssw babakamyljanovssw deleted the fix-acknowledgements branch February 7, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants