Add tash command for power management monitoring #4185

hasw7569 · 2020-02-05T06:58:23Z

I added "pminfo" tash command for power management monitoring.
It displays wakeup reason and stay time of each pm state and activities of registered driver in each pm state.
also pminfo command displays accumulated stay time for each pm state.

seinfra · 2020-02-05T07:01:22Z

Target : [b6ae987ddaef13dc3784419cc93a312f553c2d7f] - Code Rule Check OK.

seinfra · 2020-02-05T07:01:32Z

Target : [b6ae987ddaef13dc3784419cc93a312f553c2d7f] - Code Rule Check (C++) OK.

seinfra · 2020-02-05T07:07:12Z

Target : [fd9b077d19c776bbc45c6efe9e71993701470018] - Code Rule Check OK.

seinfra · 2020-02-05T07:07:21Z

Target : [fd9b077d19c776bbc45c6efe9e71993701470018] - Code Rule Check (C++) OK.

seinfra · 2020-02-05T07:34:10Z

Target : [00399aa8413e34b7d4a06e383f3f3385a6f410a0] - Code Rule Check (C++) OK.

seinfra · 2020-02-05T07:40:25Z

Target : [bf5f0cbc6d082bb337c1dceeef0a65b3af153154] - Code Rule Check (C++) OK.

YiHyunJin · 2020-02-05T08:15:23Z

os/fs/procfs/Make.defs

@@ -66,6 +66,7 @@ endif
 ifeq ($(CONFIG_ARCH_BOARD_SIDK_S5JT200),y)
 CFLAGS+=-I$(TOPDIR)/../apps/include/netutils/wifi
 endif
+CFLAGS+=-I$(TOPDIR)/pm


If pm is config, it would be better to add it.

pm is directory name.

YiHyunJin · 2020-02-05T08:47:11Z

os/fs/procfs/fs_procfsproc.c


 #ifdef CONFIG_SCHED_CPULOAD
 #include <tinyara/clock.h>
 #endif

 #include <arch/irq.h>
+#include <pm.h>


How about this change?
#if defined(CONFIG_PM) && defined(CONFIG_PM_METRICS) #include <pm.h> #endif
and line 84

I agree.
I will update soon.

jeongchanKim · 2020-02-06T02:20:02Z

apps/system/utils/utils_pminfo.c

+	const char* local = buf;
+	int ret = ERROR;
+	while(*local) {
+		if(*local == ' ') {


Please add space after 'if'

jeongchanKim · 2020-02-06T02:20:14Z

apps/system/utils/utils_pminfo.c

+{
+	const char* local = buf;
+	int ret = ERROR;
+	while(*local) {


Please add space after while

jeongchanKim · 2020-02-06T02:24:27Z

os/fs/procfs/fs_procfsproc.c

@@ -256,6 +266,12 @@ static const struct proc_node_s g_groupfd = {
 	"group/fd", "fd", (uint8_t)PROC_GROUP_FD, DTYPE_FILE	/* Group file descriptors */
 };

+#if defined(CONFIG_PM) && defined(CONFIG_PM_METRICS)
+static const struct proc_node_s g_pminfo = {
+	"pminfo", "pminfo", (uint8_t)PROC_PMINFO, DTYPE_FILE	/* Group file descriptors */


Please change the description. This is not for group file descriptors.

jeongchanKim · 2020-02-06T02:25:21Z

os/pm/pm_activity.c

+			FAR sq_entry_t *node = NULL;
+			int flag = ERROR;
+			for (node = sq_peek(&(pdom->accum_history)); node; node = node->flink) {
+				if (!strcmp(((struct pm_accumchange_s*)node)->name, callbacks->name)) {


You'd better use strncmp instead of strcmp.

callbacks can be dereferencing. Please check that first.

jeongchanKim · 2020-02-06T02:29:55Z

os/pm/pm_activity.c

@@ -150,6 +170,11 @@ void pm_activity(int domain, int priority)
 			tmp         = pdom->accum;
 			pdom->stime = now;
 			pdom->accum = 0;
+			#ifdef CONFIG_PM_METRICS


Please remove tabs before #ifdef.

jeongchanKim · 2020-02-06T02:30:24Z

os/pm/pm_addhistory.c

+ * language governing permissions and limitations under the License.
+ *
+ ****************************************************************************/
+/****************************************************************************


This is your own code. You don't need to add Nuttx license.

jeongchanKim · 2020-02-06T02:30:56Z

os/pm/pm_addhistory.c

+
+	node = (struct pm_statechange_s *)pm_alloc(1, sizeof(struct pm_statechange_s));
+
+	node->state = state;


node can be NULL, then it can be dereferencing.

jeongchanKim · 2020-02-06T02:31:17Z

os/pm/pm_changestate.c

@@ -296,7 +296,9 @@ int pm_changestate(int domain_indx, enum pm_state_e newstate)
 	pm_changeall(domain_indx, newstate);
 	if (newstate != PM_RESTORE) {
 		g_pmglobals.domain[domain_indx].state = newstate;
-
+		#ifdef CONFIG_PM_METRICS


Please remove tabs before #ifdef.

jeongchanKim · 2020-02-06T02:31:27Z

os/pm/pm_checkstate.c

@@ -145,6 +147,32 @@ enum pm_state_e pm_checkstate(int domain)
 		 */

 		(void)pm_update(domain, accum);
+		#ifdef CONFIG_PM_METRICS


Please remove tabs before #ifdef.

jeongchanKim · 2020-02-06T02:31:52Z

os/pm/pm_checkstate.c

+				FAR sq_entry_t *dest = NULL;
+
+				do
+				{


Please remove enter between do and {.

jeongchanKim · 2020-02-06T02:32:13Z

os/pm/pm_checkstate.c

+				} while (dest);
+
+				for (node = sq_peek(&(pdom->accum_history)); node; node = node->flink) {
+					struct pm_accumchange_s *insert_node = (struct pm_accumchange_s *)pm_alloc(1, sizeof(struct pm_accumchange_s));


Please check insert_node is NULL or not.

jeongchanKim · 2020-02-06T02:32:47Z

os/pm/pm_metrics.h

+struct pm_accumchange_s {
+	sq_entry_t entry;
+	int16_t accum;
+#ifdef CONFIG_PM


Why only name should have condition for CONFIG_PM?
And if you want to use CONFIG_XX, you'd better include <tinyara/config.h>

jeongchanKim · 2020-02-06T02:33:39Z

os/pm/pm_register.c

+
+			initnode = (struct pm_accumchange_s *)pm_alloc(1, sizeof(struct pm_accumchange_s));
+
+			initnode->accum = 0;


Check dereferencing.

jeongchanKim · 2020-02-06T02:33:58Z

os/pm/pm_unregister.c

@@ -94,6 +95,16 @@ int pm_unregister(FAR struct pm_callback_s *callbacks)
 	ret = pm_lock();
 	if (ret == OK) {
 		dq_rem(&callbacks->entry, &g_pmglobals.registry);
+		#ifdef CONFIG_PM_METRICS


Remove unnecessary tabs.

jeongchanKim · 2020-02-06T02:34:11Z

os/pm/pm_unregister.c

+			FAR sq_entry_t *node = NULL;
+
+			for(node = sq_peek(&(g_pmglobals.domain[callbacks->domain].accum_history)); node; node = node->flink) {
+				if(!strcmp(((struct pm_accumchange_s*)node)->name, callbacks->name)) {


Please use strncmp instead of strcmp.

jeongchanKim · 2020-02-06T02:35:00Z

apps/system/utils/utils_pminfo.c

+ * language governing permissions and limitations under the License.
+ *
+ ****************************************************************************/
+/****************************************************************************


You don't need to add Nuttx License in this file.

jeongchanKim · 2020-02-06T02:36:16Z

apps/system/utils/utils_pminfo.c

+
+static void pminfo_print_values(char *buf)
+{
+	int i, j;


Please separate the declaration.

jeongchanKim · 2020-02-06T02:36:41Z

apps/system/utils/utils_pminfo.c

+
+	for (i = 0; pm_info[i]; i = i + 3 + driver_cnt) {
+
+		if(!strcmp(pm_info[i], "END")) {


Please use strncmp instead of strcmp.

jeongchanKim · 2020-02-19T09:08:33Z

os/pm/pm_unregister.c

+		struct pm_domain_s *pdom = &g_pmglobals.domain[callbacks->domain];
+		struct pm_accumchange_s *node = NULL;
+
+		for (node = (struct pm_accumchange_s*)sq_peek(&(pdom->each_accum)); node; node = (struct pm_accumchange_s*)(node->entry.flink)) {


Please add space before '*'.

jeongchanKim · 2020-02-19T09:09:43Z

os/pm/pm_activity.c

@@ -150,6 +179,11 @@ void pm_activity(int domain, int priority)
 			tmp         = pdom->accum;
 			pdom->stime = now;
 			pdom->accum = 0;
+#ifdef CONFIG_PM_METRICS
+			for (node = (struct pm_accumchange_s*)sq_peek(&(pdom->each_accum)); node; node = (struct pm_accumchange_s*)(node->entry.flink)) {


Please add space before '*'.

jeongchanKim · 2020-02-19T09:11:27Z

os/pm/Kconfig

@@ -42,6 +42,9 @@ config PM_METRICS_DURATION
 	int "History Duration (secs)"
 	default 60

+config PM_HISTORY_COUNT
+	int "History Count"
+	default 5


Could you add ---help--- for explanation about this config?

Taejun-Kwon · 2020-02-19T09:09:03Z

os/pm/pm_activity.c

+		} else {
+			for (node = (struct pm_accumchange_s*)sq_peek(&(pdom->each_accum)); node; node = (struct pm_accumchange_s*)(node->entry.flink)) {
+				if (!strncmp(node->name, name, strlen(name) + 1)) {
+					uint32_t next_accum = node->accum + priority;


next_accum is unnecessary, actually.

Taejun-Kwon · 2020-02-19T09:10:33Z

os/fs/procfs/fs_procfs.c

@@ -166,6 +167,10 @@ static const struct procfs_entry_s g_procfsentries[] = {
 	{"ereport/*", &ereport_operations},
 #endif

+#if defined(CONFIG_PM) && defined(CONFIG_PM_METRICS)


Like above cases, CONFIG_FS_PROCFS_EXCLUDE_PM may needed.

Taejun-Kwon · 2020-02-19T09:13:02Z

os/fs/procfs/fs_procfspminfo.c

+	pminfo_close,				/* close */
+	pminfo_read,				/* read */
+	NULL,						/* write */
+	NULL,						/* dup */


This is one of file operation, also working with fd, so dup & stat are necessary.

Taejun-Kwon · 2020-02-19T09:16:11Z

os/pm/pm_addhistory.c

+	/* Create an initial state change node with NORMAL state and bootup time */
+
+	node = (struct pm_statechange_s *)pm_alloc(1, sizeof(struct pm_statechange_s));
+	if (node == NULL) {


minor one you don't have to modify but below is more good habit for future work.
if (a != b) {
return; //ENOMEM for your case.
}

do something

Thank you for your comment : )

Taejun-Kwon · 2020-02-19T09:17:59Z

os/pm/pm_addhistory.c

+		tail = (struct pm_statechange_s*)dq_tail(&(pdom->history));
+		if (tail != NULL) {
+			pdom->state_stay[tail->state] += node->timestamp - tail->timestamp;
+		}


In my opinion, if tail is null, then we don't have to push it to history(below progress)...isn't it?

Thank you for your comment : )
but I don't understand what you mean.
Do you mean we don't have to push "tail" into history?

I mean below, if tail contains most recent history...

if (tail == NULL) { return; } pdom->state_stay.....

Ignore this If I am wrong.

Taejun-Kwon · 2020-02-19T09:18:54Z

os/pm/pm_addhistory.c

+ *
+ ****************************************************************************/
+#ifdef CONFIG_PM_METRICS
+void pm_addhistory(int domain, int state)


This is one of kernel feature, you had better modify type to int, instead of void.
Then you can return error values which is defined in errno.h

Taejun-Kwon · 2020-02-19T09:20:21Z

os/pm/pm_checkstate.c

+			dest = (struct pm_accumchange_s*)sq_remfirst(&(history->accum_history));
+			while (dest) {
+				free(dest);
+				dest = (struct pm_accumchange_s*)sq_remfirst(&(history->accum_history));
+			}


To clean code, how about do-while?

seinfra · 2020-02-20T10:55:15Z

Target : [17e8ea1e9a4416f95b32b4145ea3ebedbaf334f8] - Code Rule Check (C++) OK.

seinfra · 2020-02-20T10:55:27Z

Target : [17e8ea1e9a4416f95b32b4145ea3ebedbaf334f8] - Code Rule Check OK.

sunghan-chang · 2020-02-21T01:41:15Z

apps/system/utils/Makefile

@@ -153,6 +153,10 @@ ifeq ($(CONFIG_ENABLE_UPTIME),y)
 CSRCS += utils_uptime.c
 endif

+ifeq ($(CONFIG_PM)$(CONFIG_PM_METRICS),yy)


PM_METRICS can be enabled when PM is enabled so that you could remove the PM conditional. It's redundant.

sunghan-chang · 2020-02-21T01:42:16Z

apps/system/utils/utils_pminfo.c

+#define PM_INFO_MAX 100
+
+static char* pm_state[5] = {
+		"NORMAL",


Let's remove a tab. It has two tabs.

sunghan-chang · 2020-02-21T01:42:52Z

apps/system/utils/utils_pminfo.c

+	for (i = 0; i < loop; i++) {
+		printf("----------------------");
+	}
+}


What's the purpose of this function?

This function print line to separate entries.
I think this function improves readability for user.

sunghan-chang · 2020-02-21T05:04:28Z

os/arch/arm/src/stm32l4/stm32l4_serial.c

@@ -769,7 +770,7 @@ static struct
  bool serial_suspended;
 } g_serialpm =
  {
-    .pm_cb.name = "serial",
+    .pm_cb.name = SERIAL_NAME,


This new definition is used only here. Do we need to use this definition only for here?

sunghan-chang · 2020-02-21T05:04:53Z

os/arch/arm/src/stm32l4/stm32l4_serial.c

@@ -182,6 +182,7 @@
 #endif
 #if defined(CONFIG_PM)
 #  define PM_IDLE_DOMAIN             0 /* Revisit */
+#define SERIAL_NAME "serial"


serial name "serial" ?

sunghan-chang · 2020-02-21T05:06:30Z

os/fs/procfs/fs_procfs.c

@@ -166,6 +167,10 @@ static const struct procfs_entry_s g_procfsentries[] = {
 	{"ereport/*", &ereport_operations},
 #endif

+#if defined(CONFIG_PM_METRICS) && !defined(CONFIG_FS_PROCFS_EXCLUDE_PMINFO)


CONFIG_FS_PROCFS_EXCLUDE_PMINFO is enough. Because FS_PROCFS_EXCLUDE_PMINFO checks PM_METRICS.

Even if CONFIG_PM_METRICS is disabled, the default value of CONFIG_FS_PROCFS_EXCLUDE_PMINFO is "n".
So we should check CONFIG_PM_METRICS, otherwise "pminfo_operations" is not defined.
"pminfo_operations" in "fs_procfspminfo.c" can be defined when CONFIG_PM_METRICS is enabled.

sunghan-chang · 2020-02-21T05:07:22Z

os/fs/procfs/fs_procfspminfo.c

+ * Included Files
+ ****************************************************************************/
+
+#include <tinyara/config.h>


This file does not include CONFIG_XX. Unnecessary.

sunghan-chang · 2020-02-21T05:08:10Z

os/fs/procfs/fs_procfspminfo.c

+
+static int pminfo_open(FAR struct file *filep, FAR const char *relpath, int oflags, mode_t mode);
+static int pminfo_close(FAR struct file *filep);
+static ssize_t pminfo_read(FAR struct file *filep, FAR char *buffer, size_t buflen);


header for ssize_t

seinfra · 2020-02-24T06:07:31Z

Target : [8dba31b] - Code Rule Check (C++) OK.

seinfra · 2020-02-24T06:07:32Z

Target : [8dba31b] - Code Rule Check OK.

seinfra · 2020-03-06T05:58:24Z

Target : [3f144b7] - Code Rule Check (C++) OK.

seinfra · 2020-03-06T05:58:25Z

Target : [3f144b7] - Code Rule Check OK.

I added accum_history variable into pm_domain_s to record activity of each driver When the power management state changes, It records the activity of each driver and current power management state and timestamp into history variable. so, user can check stay time of each power management state. user can also check the activity of registerd drivers in each power management state.

I added pminfo tash command for power management monitoring. pminfo command displays wakeup reason and stay time of each power management state and activity of each registered driver into pm system. also pminfo command displays accumulated stay time for each state. ex) TASH>>pminfo STATE | STAY(SEC) | --------------------- NORMAL | 21 | --------------------- IDLE | 17 | --------------------- STANDBY | 15 | --------------------- SLEEP | 46 | --------------------- STATE | STAY(SEC) | WAKEUP REASON | drv_name , activity | ----------------------------------------------------------- NORMAL | 10 | None | serial , 0 | ----------------------------------------------------------- IDLE | 5 | None | serial , 0 | ----------------------------------------------------------- STANDBY | 7 | None | serial , 0 | ----------------------------------------------------------- SLEEP | 5 | serial | serial , 20 | -----------------------------------------------------------

update pm_activity() call on some boards

I added fs_procfspminfo.c file to handle pminfo file operations. The pminfo_read function writes power management monitoring informations to the buffer.

jeongarmy · 2020-03-19T04:17:02Z

apps/system/utils/utils_pminfo.c

+	pm_data pm_info[PM_INFO_MAX];
+
+	pm_info[0] = buf;
+	for (i = 0; strncmp(pm_info[i], "eof", strlen("eof") + 1) != 0; i++) {


I think you'd better to define "eof"

jeongarmy · 2020-03-19T04:18:53Z

apps/system/utils/utils_pminfo.c

+	}
+	printf("\n---------------------\n\n\n");
+
+	for (i = 5; strncmp(pm_info[i], "eof", strlen("eof") + 1) != 0; i += j + 4) {


I think you need to calculate count instead of hardcode

jeongarmy · 2020-03-19T04:21:48Z

os/fs/procfs/fs_procfspminfo.c

+	pminfo_open,				/* open */
+	pminfo_close,				/* close */
+	pminfo_read,				/* read */
+	NULL,						/* write */


please change alignment

jeongarmy

please find comments

jeongarmy · 2020-03-19T04:25:34Z

os/include/tinyara/pm/pm.h

@@ -450,6 +452,7 @@ int pm_unregister(FAR struct pm_callback_s *callbacks);
 *   priority - Activity priority, range 0-9.  Larger values correspond to
 *     higher priorities.  Higher priority activity can prevent the system
 *     from entering reduced power states for a longer period of time.
+ *   name - name of the registered driver or application


Application can register it?

jeongarmy · 2020-03-19T04:25:49Z

os/include/tinyara/pm/pm.h

+ * Name: pm_addhistory
+ *
+ * Description:
+ *   This function add history into pm structure.


jeongarmy · 2020-03-19T04:26:23Z

os/pm/pm_activity.c

@@ -58,12 +58,15 @@

 #include <stdint.h>
 #include <assert.h>
+#include <queue.h>


#ifdef CONFIG_PM_METRICS

jeongarmy · 2020-03-19T04:26:44Z

os/pm/pm_activity.c

@@ -150,6 +179,14 @@ void pm_activity(int domain, int priority)
 			tmp         = pdom->accum;
 			pdom->stime = now;
 			pdom->accum = 0;
+#ifdef CONFIG_PM_METRICS
+			for (node = (struct pm_accumchange_s *)sq_peek(&(pdom->each_accum)); node; node = (struct pm_accumchange_s *)(node->entry.flink)) {


tizen-build · 2020-04-10T03:10:27Z

Target : [3f144b7] - Code Rule Check OK.

deepaksrma · 2020-05-15T10:57:20Z

os/include/tinyara/pm/pm.h

@@ -306,6 +307,7 @@ struct pm_callback_s {
 	struct dq_entry_s entry;   /* Supports a doubly linked list */

 	char name[MAX_PM_CALLBACK_NAME];	/* Name of driver which register callback */


maintain same tab space for comments

deepaksrma · 2020-05-15T10:57:51Z

os/include/tinyara/pm/pm.h

@@ -306,6 +307,7 @@ struct pm_callback_s {
 	struct dq_entry_s entry;   /* Supports a doubly linked list */

 	char name[MAX_PM_CALLBACK_NAME];	/* Name of driver which register callback */
+	int domain;	/* Number of domain */


same as above

deepaksrma · 2020-05-15T11:01:02Z

os/include/tinyara/pm/pm.h

@@ -631,12 +651,13 @@ enum pm_state_e pm_querystate(int domain);
 #define pm_initialize()
 #define pm_register(cb)			(0)
 #define pm_unregister(cb)		(0)


try to maintain the same tab space here also

deepaksrma · 2020-05-15T11:01:31Z

os/include/tinyara/pm/pm.h

-#define pm_relax(domain,state)
+#define pm_activity(domain, prio, name)
+#define pm_stay(domain, state)
+#define pm_relax(domain, state)
 #define pm_checkstate(domain)		(0)
 #define pm_changestate(domain, state)	(0)
 #define pm_querystate(domain)        (0)


same as above

dineshdas-samsung · 2021-06-11T07:54:59Z

os/fs/procfs/fs_procfspminfo.c

+		return -ENOMEM;
+	}
+
+	/* The copy the file attributes from the old attributes to the new */


Can we please remove "The" or may be we can modify the comment line ?

dineshdas-samsung · 2021-06-11T08:03:33Z

apps/system/utils/utils_pminfo.c

@@ -0,0 +1,146 @@
+/****************************************************************************
+ *
+ * Copyright 2020 Samsung Electronics All Rights Reserved.


Can we change the year to 2021?

tizen-build · 2023-03-21T02:16:26Z

Target : [3f144b7] - Code Rule Check OK.

hasw7569 force-pushed the tash_test branch from b6ae987 to fd9b077 Compare February 5, 2020 07:04

hasw7569 force-pushed the tash_test branch from fd9b077 to 00399aa Compare February 5, 2020 07:33

This comment has been minimized.

Sign in to view

hasw7569 force-pushed the tash_test branch from 00399aa to bf5f0cb Compare February 5, 2020 07:39

This comment has been minimized.

Sign in to view

YiHyunJin reviewed Feb 5, 2020

View reviewed changes

jeongchanKim reviewed Feb 6, 2020

View reviewed changes

os/pm/pm_checkstate.c Outdated

FAR sq_entry_t *dest = NULL;

do

{

Copy link

Contributor

jeongchanKim Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove enter between do and {.

jeongchanKim reviewed Feb 6, 2020

View reviewed changes

jeongchanKim reviewed Feb 19, 2020

View reviewed changes

Taejun-Kwon reviewed Feb 19, 2020

View reviewed changes

hasw7569 force-pushed the tash_test branch from 4bd5d58 to 17e8ea1 Compare February 20, 2020 10:53

sunghan-chang reviewed Feb 21, 2020

View reviewed changes

hasw7569 force-pushed the tash_test branch from 17e8ea1 to 8dba31b Compare February 24, 2020 06:05

hasw7569 force-pushed the tash_test branch from 8dba31b to 3f144b7 Compare March 6, 2020 05:57

hasw7569 added 4 commits March 6, 2020 14:58

arch/arm/src : update pm_activity() call

e65dbec

update pm_activity() call on some boards

fs/procfs : Add pminfo file operations

3f144b7

I added fs_procfspminfo.c file to handle pminfo file operations. The pminfo_read function writes power management monitoring informations to the buffer.

jeongarmy reviewed Mar 19, 2020

View reviewed changes

deepaksrma reviewed May 15, 2020

View reviewed changes

dineshdas-samsung reviewed Jun 11, 2021

View reviewed changes


		node = (struct pm_statechange_s *)pm_alloc(1, sizeof(struct pm_statechange_s));

		node->state = state;


		initnode = (struct pm_accumchange_s *)pm_alloc(1, sizeof(struct pm_accumchange_s));

		initnode->accum = 0;


		for (i = 0; pm_info[i]; i = i + 3 + driver_cnt) {

		if(!strcmp(pm_info[i], "END")) {

		@@ -306,6 +307,7 @@ struct pm_callback_s {
		struct dq_entry_s entry; /* Supports a doubly linked list */

		char name[MAX_PM_CALLBACK_NAME]; /* Name of driver which register callback */

Add tash command for power management monitoring #4185

Are you sure you want to change the base?

Add tash command for power management monitoring #4185

Conversation

hasw7569 commented Feb 5, 2020 • edited Loading

seinfra commented Feb 5, 2020

seinfra commented Feb 5, 2020

seinfra commented Feb 5, 2020

seinfra commented Feb 5, 2020

seinfra commented Feb 5, 2020

This comment has been minimized.

seinfra commented Feb 5, 2020

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeongchanKim Feb 6, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeongchanKim Feb 6, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hasw7569 Feb 20, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seinfra commented Feb 20, 2020

seinfra commented Feb 20, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hasw7569 Feb 24, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seinfra commented Feb 24, 2020

seinfra commented Feb 24, 2020

seinfra commented Mar 6, 2020

seinfra commented Mar 6, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeongarmy left a comment

Choose a reason for hiding this comment

hasw7569 commented Feb 5, 2020 •

edited

Loading

jeongchanKim Feb 6, 2020 •

edited

Loading

jeongchanKim Feb 6, 2020 •

edited

Loading

hasw7569 Feb 20, 2020 •

edited

Loading

hasw7569 Feb 24, 2020 •

edited

Loading