arch/arm/armv7-a: Modify to printing LR when NULL executing fault #6654
+53
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR is from #6643. |
kishore-sn
reviewed
Jan 31, 2025
os/binfmt/libelf/libelf_sections.c
Outdated
| if (g_bin_addr_list[bin_idx].text_addr != 0) { | ||
| start_addr = g_bin_addr_list[bin_idx].text_addr; | ||
| end_addr = start_addr + g_bin_addr_list[bin_idx].text_size; | ||
| if (start_addr < addr && addr < end_addr) { |
There was a problem hiding this comment.
I think it must be start_addr <= addr
The elf_is_text_addr funtion returns whether the address which is argument is within the text section of an ELF binary registered by binfmt. Signed-off-by: eunwoo.nam <[email protected]>
ewoodev
force-pushed
the
WORK-250120_prefetch_fault
branch
from
061801f to
b6c08dc
Compare
If null is executed, prefetch abort is occuring. But PC and R15 value is 0x00000000. For debugging this fault, we need to save LR(R14) and print it in fault log. Therefore, Add print LR in pretech abort logs. And if PC is not text address, replace system exception location to LR(R14). Signed-off-by: eunwoo.nam <[email protected]>
If PC becomes invalid causing a fault, we replace the system_exception_location with the address at LR. However, since the value of LR is the address to execute after returning, the actual address that caused the fault is the address -4. Therefore, when replacing LR with exception location, it is corrected to address - 4. This will help avoid confusion for developers working on debugging applications such as TRAP. Signed-off-by: eunwoo.nam <[email protected]>
ewoodev
force-pushed
the
WORK-250120_prefetch_fault
branch
from
b6c08dc to
3c569ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.