Fixed convert method

SciML · Feb 28, 2022 · 7e95379 · 7e95379 · jonniedie · Feb 28, 2022
1 parent 8d7352c
commit 7e95379
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "ComponentArrays"
 uuid = "b0b7db55-cfe3-40fc-9ded-d10e2dbeff66"
 authors = ["Jonnie Diegelman <[email protected]>"]
-version = "0.11.9"
+version = "0.11.10"
 
 [deps]
 ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"

diff --git a/src/similar_convert_copy.jl b/src/similar_convert_copy.jl
@@ -53,7 +53,7 @@ end
 function Base.convert(::Type{ComponentArray{T1,N,A1,Ax1}}, x::ComponentArray{T2,N,A2,Ax2}) where {T1,T2,N,A1,A2,Ax1,Ax2}
     return T1.(x)
 end
-Base.convert(::Type{<:Array}, x::ComponentArray) = convert(Array, getdata(x))
+Base.convert(T::Type{<:Array}, x::ComponentArray) = convert(T, getdata(x))
 
 Base.convert(::Type{Cholesky{T1,Matrix{T1}}}, x::Cholesky{T2,<:ComponentArray}) where {T1,T2} = Cholesky(Matrix{T1}(x.factors), x.uplo, x.info)
 

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -338,6 +338,7 @@ end
     @test convert(typeof(cmat), cmat) == cmat
 
     @test convert(Array, ca) == getdata(ca)
+    @test convert(Matrix{Float32}, cmat) isa Matrix{Float32}
 end
 
 @testset "Broadcasting" begin