Better test coverage for linear algebra stuff

SciML · Mar 30, 2022 · ea80ac9 · ea80ac9 · jonniedie · Mar 30, 2022
1 parent cf6dd6e
commit ea80ac9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/linear_algebra.jl b/src/linear_algebra.jl
@@ -9,7 +9,6 @@ function ArrayInterface.lu_instance(x::ComponentMatrix)
 end
 
 # Helpers for dealing with adjoints and such
-_first_axis(x) = FlatAxis()
 _first_axis(x::AbstractComponentVecOrMat) = getaxes(x)[1]
 
 _second_axis(x::AbstractMatrix) = FlatAxis()
@@ -38,9 +37,6 @@ for op in [:*, :\, :/]
                 ax2 = _out_axes($op, aᵀ, B)[2]
                 return $adj(ComponentArray(cᵀ', ax2))
             end
-            function Base.$op(A::$Adj{T,<:CV}, B::CV) where {T<:Number, CV<:ComponentVector{T}}
-                return $op(getdata(A), getdata(B))
-            end
             function Base.$op(A::$Adj{T,<:CV}, B::CV) where {T<:Real, CV<:ComponentVector{T}}
                 return $op(getdata(A), getdata(B))
             end

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -517,6 +517,7 @@ end
         @test getaxes(ab_cd' \ cd) == (AB,)
         @test getaxes(cd' / ab_cd) == (FlatAxis(), AB)
         @test getaxes(ab' / ab_cd') == (FlatAxis(), CD)
+        @test getaxes(ab_cd \ ab_cd) == (CD, CD)
     end
 
     # Issue #33
@@ -536,6 +537,9 @@ end
     @test getaxes((s1_D * s2_D) * in2) == getaxes(s1_D * (s2_D * in2)) == (Axis(y1 = 1),)
     @test getaxes((s2_D * s1_D) * in1) == getaxes(s2_D * (s1_D * in1)) == (Axis(y2 = 1),)
     @test getaxes(out1' * (s1_D * s2_D)) == getaxes(transpose(out1) * (s1_D * s2_D)) == (FlatAxis(), Axis(u2 = 1))
+
+    @test ComponentArrays.ArrayInterface.lu_instance(cmat).factors isa ComponentMatrix
+    @test ComponentArrays.ArrayInterface.parent_type(cmat) === Matrix{Float64}
 end
 
 @testset "Plot Utilities" begin