fix some memory leak problem

src/Starward/Features/GameLauncher/GameBannerAndPost.xaml.cs

@@ -71,6 +71,9 @@ private void GameBannerAndPost_Unloaded(object sender, RoutedEventArgs e)
     {
         WeakReferenceMessenger.Default.UnregisterAll(this);
         _bannerTimer.Stop();
+        _bannerTimer.Tick -= _bannerTimer_Tick;
+        Banners = null;
+        PostGroups = null;
     }
 
 
@@ -201,7 +204,14 @@ private async Task UpdateGameNoticeAlertAsync()
                 Button_InGameNotices.Visibility = Visibility.Collapsed;
                 return;
             }
-            IsGameNoticesAlert = await _gameNoticeService.IsNoticeAlertAsync(CurrentGameId.GameBiz);
+            if (AppSetting.DisableGameNoticeRedHot)
+            {
+                IsGameNoticesAlert = false;
+            }
+            else
+            {
+                IsGameNoticesAlert = await _gameNoticeService.IsNoticeAlertAsync(CurrentGameId.GameBiz);
+            }
         }
         catch (Exception ex)
         {

src/Starward/Features/GameLauncher/GameLauncherSettingDialog.xaml

@@ -164,11 +164,6 @@
                             <Grid Width="40"
                                   Height="40"
                                   CornerRadius="8">
-                                <FontIcon HorizontalAlignment="Center"
-                                          VerticalAlignment="Center"
-                                          FontSize="20"
-                                          Glyph="&#xE8A9;"
-                                          IsTextScaleFactorEnabled="False" />
                                 <sc:CachedImage Width="40"
                                                 Height="40"
                                                 Source="{x:Bind CurrentGameBizIcon.GameIcon, FallbackValue={x:Null}}" />

src/Starward/Features/GameLauncher/GameLauncherSettingDialog.xaml.cs

@@ -50,6 +50,7 @@ public GameLauncherSettingDialog()
     {
         this.InitializeComponent();
         this.Loaded += GameLauncherSettingDialog_Loaded;
+        this.Unloaded += GameLauncherSettingDialog_Unloaded;
     }
 
 
@@ -93,7 +94,6 @@ private void FlipView_Settings_Loaded(object sender, RoutedEventArgs e)
 
 
 
-
     private void NavigationView_ItemInvoked(NavigationView sender, NavigationViewItemInvokedEventArgs args)
     {
         try
@@ -133,6 +133,14 @@ private async void GameLauncherSettingDialog_Loaded(object sender, RoutedEventAr
     }
 
 
+    private void GameLauncherSettingDialog_Unloaded(object sender, RoutedEventArgs e)
+    {
+        LatestPackageGroups = null!;
+        PreInstallPackageGroups = null!;
+        FlipView_Settings.Items.Clear();
+    }
+
+
 
 
     [RelayCommand]

src/Starward/Features/GameRecord/BattleChronicleWindow.xaml.cs

@@ -59,6 +59,7 @@ private void CenterInScreen()
 
     private void RootGrid_Loaded(object sender, RoutedEventArgs e)
     {
+        RootGrid.Loaded -= RootGrid_Loaded;
         _ = bbsWebBridge.LoadPageAsync();
     }
 

src/Starward/Features/GameRecord/GameRecordPage.xaml.cs

@@ -96,6 +96,10 @@ protected override async void OnLoaded()
     protected override void OnUnloaded()
     {
         WeakReferenceMessenger.Default.UnregisterAll(this);
+        NavigationViewItem_BattleChronicle.Tapped -= NavigationViewItem_BattleChronicle_Tapped;
+        NavigationViewItem_UpdateDeviceInfo.Tapped -= NavigationViewItem_UpdateDeviceInfo_Tapped;
+        CurrentRole = null;
+        GameRoleList = null!;
     }
 
 
@@ -252,7 +256,8 @@ private void InitializeNavigationViewItemVisibility()
 
     public GameRecordRole? CurrentRole
     {
-        get; set
+        get;
+        set
         {
             if (SetProperty(ref field, value))
             {

src/Starward/Features/GameRecord/Genshin/ImaginariumTheaterPage.xaml.cs

@@ -56,6 +56,14 @@ protected override async void OnLoaded()
 
 
 
+    protected override void OnUnloaded()
+    {
+        CurrentTheater = null;
+        TheaterList = null!;
+    }
+
+
+
 
     [ObservableProperty]
     private bool hasData;

src/Starward/Features/GameRecord/Genshin/SpiralAbyssPage.xaml.cs

@@ -55,6 +55,12 @@ protected override async void OnLoaded()
 
 
 
+    protected override void OnUnloaded()
+    {
+        CurrentAbyss = null;
+        AbyssList = null!;
+    }
+
 
 
     [ObservableProperty]

src/Starward/Features/GameRecord/Genshin/TravelersDiaryPage.xaml.cs

@@ -56,6 +56,16 @@ protected override async void OnLoaded()
     }
 
 
+    protected override void OnUnloaded()
+    {
+        CurrentSummary = null!;
+        SelectMonthData = null;
+        MonthDataList = null!;
+        CurrentSeries = null;
+        SelectSeries = null;
+        DayDataList = null!;
+    }
+
 
 
     [ObservableProperty]

src/Starward/Features/GameRecord/StarRail/ApocalypticShadowPage.xaml.cs

@@ -56,6 +56,13 @@ protected override async void OnLoaded()
 
 
 
+    protected override void OnUnloaded()
+    {
+        CurrentApocalypticShadow = null;
+        ApocalypticShadowList = null!;
+    }
+
+
 
     [ObservableProperty]
     private List<ApocalypticShadowInfo> apocalypticShadowList;

src/Starward/Features/GameRecord/StarRail/ForgottenHallPage.xaml.cs

@@ -56,6 +56,13 @@ protected override async void OnLoaded()
 
 
 
+    protected override void OnUnloaded()
+    {
+        CurrentForgottenHall = null;
+        ForgottenHallList = null!;
+    }
+
+
 
     [ObservableProperty]
     private List<ForgottenHallInfo> forgottenHallList;

src/Starward/Features/GameRecord/StarRail/PureFictionPage.xaml.cs

@@ -56,6 +56,13 @@ protected override async void OnLoaded()
 
 
 
+    protected override void OnUnloaded()
+    {
+        CurrentPureFiction = null;
+        PureFictionList = null!;
+    }
+
+
 
     [ObservableProperty]
     private List<PureFictionInfo> pureFictionList;

src/Starward/Features/GameRecord/StarRail/SimulatedUniversePage.xaml.cs

@@ -55,6 +55,14 @@ protected override async void OnLoaded()
 
 
 
+    protected override void OnUnloaded()
+    {
+        BasicInfo = null!;
+        CurrentRecord = null;
+        RecordBasicList = null!;
+    }
+
+
 
     [ObservableProperty]
     private SimulatedUniverseBasicStats basicInfo;

src/Starward/Features/GameRecord/StarRail/TrailblazeCalendarPage.xaml.cs

@@ -57,6 +57,18 @@ protected override async void OnLoaded()
 
 
 
+    protected override void OnUnloaded()
+    {
+        CurrentSummary = null!;
+        SelectMonthData = null;
+        MonthDataList = null!;
+        CurrentSeries = null;
+        SelectSeries = null;
+        DayDataList = null!;
+    }
+
+
+
     [ObservableProperty]
     private TrailblazeCalendarSummary currentSummary;
 

src/Starward/Features/GameRecord/ZZZ/InterKnotMonthlyReportPage.xaml.cs

@@ -59,6 +59,18 @@ protected override async void OnLoaded()
 
 
 
+    protected override void OnUnloaded()
+    {
+        base.OnUnloaded();
+        CurrentSummary = null!;
+        SelectMonthData = null;
+        MonthDataList = null!;
+        CurrentSeries = null!;
+        SelectSeries = null!;
+        DayDataList = null!;
+    }
+
+
     [ObservableProperty]
     private InterKnotReportSummary currentSummary;
 

src/Starward/Features/Screenshot/ImageViewWindow.xaml

@@ -108,7 +108,8 @@
             </Border.OpacityTransition>
             <StackPanel Orientation="Horizontal" Spacing="4">
                 <!--  缩小  -->
-                <Button Width="36"
+                <Button x:Name="Button_ZoomOut"
+                        Width="36"
                         Height="36"
                         Command="{x:Bind ZoomOutCommand}"
                         Content="&#xE71F;"
@@ -122,23 +123,25 @@
                            VerticalAlignment="Center"
                            HorizontalTextAlignment="Center" />
                 <!--  放大  -->
-                <Button Width="36"
+                <Button x:Name="Button_ZoomIn"
+                        Width="36"
                         Height="36"
                         Command="{x:Bind ZoomInCommand}"
                         Content="&#xE8A3;"
                         FontFamily="{ThemeResource SymbolThemeFontFamily}"
                         Style="{ThemeResource DateTimePickerFlyoutButtonStyle}"
                         ToolTipService.ToolTip="{x:Bind lang:Lang.ImageViewPage_ZoomIn}" />
                 <!--  旋转  -->
-                <Button Width="36"
+                <Button x:Name="Button_Rotate"
+                        Width="36"
                         Height="36"
                         Command="{x:Bind RotateCommand}"
                         Content="&#xE7AD;"
                         FontFamily="{ThemeResource SymbolThemeFontFamily}"
                         Style="{ThemeResource DateTimePickerFlyoutButtonStyle}"
                         ToolTipService.ToolTip="{x:Bind lang:Lang.ImageViewPage_Rotate}" />
                 <!--  全屏  -->
-                <Button Name="Button_FullScreen"
+                <Button x:Name="Button_FullScreen"
                         Width="36"
                         Height="36"
                         Command="{x:Bind FullScreenCommand}"
@@ -148,7 +151,7 @@
                         ToolTipService.ToolTip="{x:Bind lang:Lang.GameSettingPage_FullScreen}" />
                 <AppBarSeparator Padding="0" />
                 <!--  复制  -->
-                <Button x:Name="_Button_Copy"
+                <Button x:Name="Button_Copy"
                         Width="36"
                         Height="36"
                         Command="{x:Bind CopyImageCommand}"
@@ -163,15 +166,17 @@
                     </Button.ContentTransitions>
                 </Button>
                 <!--  打开  -->
-                <Button Width="36"
+                <Button x:Name="Button_OpenFile"
+                        Width="36"
                         Height="36"
                         Command="{x:Bind OpenFileCommand}"
                         Content="&#xE8E5;"
                         FontFamily="{ThemeResource SymbolThemeFontFamily}"
                         Style="{ThemeResource DateTimePickerFlyoutButtonStyle}"
                         ToolTipService.ToolTip="{x:Bind lang:Lang.Common_Open}" />
                 <!--  关闭  -->
-                <Button Width="36"
+                <Button x:Name="Button_Close"
+                        Width="36"
                         Height="36"
                         Command="{x:Bind CloseCommand}"
                         Content="&#xE711;"

src/Starward/Features/Screenshot/ImageViewWindow.xaml.cs

@@ -35,12 +35,11 @@ public ImageViewWindow()
     {
         this.InitializeComponent();
         InitializeWindow();
+        this.Closed += ImageViewWindow_Closed;
     }
 
 
 
-
-
     private void InitializeWindow()
     {
         Title = "Starward Screenshots Viewer";
@@ -63,6 +62,31 @@ private void InitializeWindow()
     }
 
 
+    // ImageViewWindow 内存泄漏的问题还无法解决
+    private void ImageViewWindow_Closed(object sender, WindowEventArgs args)
+    {
+        RootGrid.KeyDown -= RootGrid_KeyDown;
+        _Image.SizeChanged -= _Image_SizeChanged;
+        _Image.ImageExOpened -= _Image_ImageOpened;
+        _ScrollViewer_Image.DoubleTapped -= _ScrollViewer_Image_DoubleTapped;
+        _ScrollViewer_Image.PointerMoved -= _ScrollViewer_Image_PointerMoved;
+        _ScrollViewer_Image.PointerPressed -= _ScrollViewer_Image_PointerPressed;
+        _ScrollViewer_Image.PointerReleased -= _ScrollViewer_Image_PointerReleased;
+        _ScrollViewer_Image.PointerWheelChanged -= _ScrollViewer_Image_PointerWheelChanged;
+        _ScrollViewer_Image.Tapped -= _ScrollViewer_Image_Tapped;
+        _ScrollViewer_Image.ViewChanged -= _ScrollViewer_Image_ViewChanged;
+        Button_Close.Command = null;
+        Button_Copy.Command = null;
+        Button_FullScreen.Command = null;
+        Button_OpenFile.Command = null;
+        Button_Rotate.Command = null;
+        Button_ZoomOut.Command = null;
+        Button_ZoomIn.Command = null;
+        CurrentImage = null!;
+        ImageCollection = null;
+        this.Bindings.StopTracking();
+    }
+
 
 
     private void RootGrid_KeyDown(object sender, KeyRoutedEventArgs e)
@@ -250,9 +274,9 @@ private async Task CopyImageAsync()
             else
             {
                 ClipboardHelper.SetStorageItems(DataPackageOperation.Copy, file);
-                _Button_Copy.Content = "\xE8FB";
+                Button_Copy.Content = "\xE8FB";
                 await Task.Delay(3000);
-                _Button_Copy.Content = "\xE8C8";
+                Button_Copy.Content = "\xE8C8";
             }
         }
         catch (Exception ex)
@@ -304,7 +328,7 @@ private async Task OpenFileAsync()
     /// </summary>
     /// <param name="sender"></param>
     /// <param name="e"></param>
-    private void _ScrollViewer_Image_ViewChanged(object sender, ScrollViewerViewChangedEventArgs e)
+    private void _ScrollViewer_Image_ViewChanged(object? sender, ScrollViewerViewChangedEventArgs e)
     {
         _TextBlock_Factor.Text = (_ScrollViewer_Image.ZoomFactor * UIScale).ToString("P0");
     }

src/Starward/Features/Screenshot/ScreenshotPage.xaml.cs

@@ -65,7 +65,6 @@ protected override async void OnLoaded()
     protected override void OnUnloaded()
     {
         Watcher?.Dispose();
-        GC.Collect();
     }
 
 

src/Starward/Features/SelfQuery/SelfQueryPage.xaml.cs

@@ -163,6 +163,12 @@ protected override async void OnLoaded()
     protected override void OnUnloaded()
     {
         tokenSource?.Cancel();
+        GenshinQueryItemList = null;
+        StarRailQueryItemList = null;
+        ZZZQueryItemList = null;
+        QueryUserInfo = null;
+        SelectTypeStats = null!;
+        TypeStatsList = null!;
     }