Add performance measurement to Cart AJAX #3719
Open
+126
−59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Start capturing RUM around cart interaction to express the buyers' experience when going through Dawn. These metrics will be extracted by
perf-kit
and emitted to our data pipeline.What approach did you take?
Adding a
Performance
to be used in different cart operations.Performance.measureFromEvent
: Measure against a starting event. This is useful when we need to measure the end of an asynchronous event.Performance.measure
: Measure the time elapsed in a callback.Testing steps/scenarios
Using the demo store, add an item to the store. Afterward, using the console, type
performance.getEntriesByType("measure");
and you should see performance measurement. Here's the other different scenario to test:Demo links
Checklist