Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculate http error_timeout based upon capacity option #145

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/semian/net_http.rb
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,19 @@ def reset_exceptions
def raw_semian_options
@raw_semian_options ||= begin
@raw_semian_options = Semian::NetHTTP.retrieve_semian_configuration(address, port)
@raw_semian_options = @raw_semian_options.dup unless @raw_semian_options.nil?
unless @raw_semian_options.nil?
@raw_semian_options = @raw_semian_options.dup
calculate_error_timeout if @raw_semian_options[:capacity] && !@raw_semian_options[:error_timeout]
end
end
end

def calculate_error_timeout
capacity = @raw_semian_options[:capacity]
error_timeout = (read_timeout * capacity) / (1 - capacity)
@raw_semian_options.merge!({ error_timeout: error_timeout})
end

def resource_exceptions
Semian::NetHTTP.exceptions
end
Expand Down
23 changes: 23 additions & 0 deletions test/net_http_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,29 @@ def test_persistent_state_after_server_restart
end
end

def test_capacity_option_calculates_the_error_timeout_based_upon_read_timeout
options_with_capacity = DEFAULT_SEMIAN_OPTIONS.dup.merge!({ capacity: 0.75 })
options_with_capacity.delete(:error_timeout)
semian_configuration_proc = proc do |host, port|
options_with_capacity.merge(name: "#{host}_#{port}")
end
with_semian_configuration(semian_configuration_proc) do
http = Net::HTTP.new(HOSTNAME, TOXIC_PORT)
assert_equal 180, http.raw_semian_options[:error_timeout]
end
end

def test_capacity_option_defaults_to_error_timeout_when_both_are_provided
options_with_capacity = DEFAULT_SEMIAN_OPTIONS.dup.merge!({ capacity: 0.75 })
semian_configuration_proc = proc do |host, port|
options_with_capacity.merge(name: "#{host}_#{port}")
end
with_semian_configuration(semian_configuration_proc) do
http = Net::HTTP.new(HOSTNAME, TOXIC_PORT)
assert_equal 10, http.raw_semian_options[:error_timeout]
end
end

private

def with_semian_configuration(options = DEFAULT_SEMIAN_CONFIGURATION)
Expand Down