WIP: handles_path #2038
Draft
WIP: handles_path #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
reviewed
Oct 11, 2024
| sig { params(path: String).returns(T::Boolean) } | ||
| def handles_path?(path) | ||
| File.fnmatch("**/*.proto", path, File::FNM_PATHNAME | File::FNM_EXTGLOB) | ||
| end |
There was a problem hiding this comment.
I'm not sure this is needed since I think after the .proto change user would regenerate the relevant ruby file and trigger the file watching with appropriate constants. Mentioned verifying this as part of the issue.
There was a problem hiding this comment.
Yeah that would sense. I've never worked with .proto files. (cc @vinistock ).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.