Don't attempt to generate DSL RBIs for test files #2039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Attempting to generate DSL RBIs for test files, which are not loaded in development mode, triggers exceptions and leads to unnecessary errors. By skipping test files in our watch configuration, we can prevent these issues.
Implementation
Updated
workspace_did_change_watched_files
to skip files ending with_test.rb
and_spec.rb
, preventing unnecessary processing and exceptions.Discovered a bug during pairing with @KaanOzkan: added
compact
toflat_map
to removenil
elements from our array, ensuring theempty?
check functions correctly and preventingtapioca dsl
from running without arguments.