Assert project file existence using patterns #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
approved these changes
Oct 16, 2024
Morriar
approved these changes
Oct 18, 2024
spec/spec_with_project.rb
Outdated
| # Assert that `path` exists inside project. | ||
| # `Path` can include patterns such as `*`, useful for testing RBIs for real gems | ||
| sig { params(path: String).void } | ||
| def assert_project_file_exist_with_pattern(path) |
There was a problem hiding this comment.
Suggested change
| def assert_project_file_exist_with_pattern(path) | |
| def assert_project_file_match_pattern(path) |
There was a problem hiding this comment.
Or even shorter:
Suggested change
| def assert_project_file_exist_with_pattern(path) | |
| def assert_project_file_match(path) |
There was a problem hiding this comment.
Thanks. Changed the name.
KaanOzkan
force-pushed
the
ko/rbi-assert
branch
from
d970db6
to
80b852c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Came up in #2046
Implementation
Use the built in pattern support for
Dir[]Tests