-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use node 20 #7145
Open
seuros
wants to merge
2
commits into
SigNoz:main
Choose a base branch
from
seuros:use_node20
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: use node 20 #7145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to bbfff90 in 1 minute and 21 seconds
More details
- Looked at
42
lines of code in3
files - Skipped
1
files when reviewing. - Skipped posting
7
drafted comments based on config settings.
1. .github/workflows/playwright.yaml:15
- Draft comment:
Node version upgraded to 20.x. Ensure all tooling (e.g. Playwright) is compatible with Node 20. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
2. frontend/.nvmrc:1
- Draft comment:
nvmrc updated to 20.18.3. Consider adding a newline at the end of the file for consistency. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
3. frontend/package.json:67
- Draft comment:
New dependency 'cross-spawn' (7.0.5) added. Verify if it is required in dependencies or if it should be moved to devDependencies. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is asking the PR author to verify the necessity of a dependency, which is against the rules. It does not provide a specific suggestion or point out a clear issue with the code.
4. .github/workflows/playwright.yaml:15
- Draft comment:
Node version updated to 20.x. Confirm that all CI scripts and dependencies are compatible with Node 20. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
5. frontend/.nvmrc:1
- Draft comment:
Updated Node version to 20.18.3. Consider ensuring a trailing newline for consistency. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
6. frontend/package.json:27
- Draft comment:
Engine requirement updated to Node 20.18.3. Consider updating the '@types/node' dev dependency for Node 20 API support. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50%
This is a dependency-related comment, which the rules explicitly say to ignore. Even though it's technically correct that @types/node should match the Node version, the rules state "Do NOT comment on dependency changes, library versions that you don't recognize, or anything else related to dependencies." This is a clear case of a dependency-related comment.
The comment is technically correct and could prevent TypeScript issues. Maybe dependency-related comments should be allowed when they directly impact type safety?
No - the rules are very clear about not commenting on dependencies. The build system or TypeScript compiler will catch any type incompatibilities if they exist.
Delete this comment as it violates the explicit rule about not commenting on dependency changes, even though it's technically correct advice.
7. frontend/package.json:70
- Draft comment:
New dependency 'cross-spawn' added. Verify that it is necessary and that its version meets cross-platform requirements. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
Workflow ID: wflow_5aODFi0BkBBWMHj2
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgraded to node 20.
The actual version 16, was causing lot of warning in the log.
Additionally version 16 is OEL for 2 years.
Important
Update Node.js version to 20 across the project to address warnings and end-of-life status of version 16.
16.x
to20.x
in.github/workflows/playwright.yaml
.frontend/.nvmrc
from16.15.0
to20.18.3
.package.json
to require Node.js version>=20.18.3
.cross-spawn
version7.0.5
topackage.json
dependencies.This description was created by
for bbfff90. It will automatically update as commits are pushed.