Include frontend with oss query-service #7247
Open
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#6696 updated
ee/query-service/Dockerfile
but didn't updatepkg/query-service/Dockerfile
This causes
query-service
fail to start when usingoss
tagged images.Workaround is to pass
SIGNOZ_WEB_ENABLED=false
env but it's not obvious because previously it just worked.Related Issues / PR's
Screenshots
NA
Affected Areas and Manually Tested Areas
Important
Fixes
query-service
startup failure by including frontend directory inpkg/query-service/Dockerfile
.pkg/query-service/Dockerfile
, addedCOPY frontend/build/ /etc/signoz/web/
to include the frontend directory in theoss
tagged images.query-service
due to missing frontend directory when usingoss
tagged images.SIGNOZ_WEB_ENABLED=false
is no longer necessary.This description was created by
for bcd62bc. It will automatically update as commits are pushed.