Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for getting account fields #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add documentation for getting account fields #5

wants to merge 3 commits into from

Conversation

eafif
Copy link

@eafif eafif commented Apr 2, 2019

No description provided.

@eafif eafif requested a review from calvincorreli April 2, 2019 01:47
calvincorreli
calvincorreli approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@calvincorreli calvincorreli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One comment.

README.md Outdated Show resolved Hide resolved
eafif added 2 commits April 1, 2019 21:54
@eafif
Update README.md
b08fa82
@eafif
remove the json specification
9504526 
With the json specification, the `...` was being highlighted as invalid json
@eafif
Copy link
Author

eafif commented Apr 2, 2019

@calvincorreli added the .... Should I merge it?

@calvincorreli
Copy link
Contributor

Let's wait till we have deployed the API change tomorrow morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvincorreli calvincorreli calvincorreli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eafif @calvincorreli