Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create endpoints for Persons, Sources and City. Move private info to env file. #32

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

said-yolcu
Copy link
Collaborator

I have created endpoints for Ordinary Person, Unordinary Person, Written Source, Secondary Source, and City. I have moved private information to .env file. Also dockerfile and docker compose are altered. Yet docker compose needs to be further changed, as of now the correct build order between db and web_api is not ensured. Therefore to run the program in containers you need to run the following commands in order:

docker compose up -d db
docker compose up -d web_api

…ce, Secondary Source, and City. Move private information to env file.
@said-yolcu said-yolcu added enhancement New feature or request backend Backend related needs review Confirmation needed labels Feb 11, 2025
@said-yolcu said-yolcu requested a review from Simurgan February 11, 2025 16:45
@said-yolcu said-yolcu self-assigned this Feb 11, 2025
Copy link
Owner

@Simurgan Simurgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The containers works as expected. The changes in the City model has been discussed in the communication channel.

@Simurgan Simurgan merged commit d517e98 into backend Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related enhancement New feature or request needs review Confirmation needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants