Require skull texture lookup on paper servers #7152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
bug
Fusezion
approved these changes
Oct 17, 2024
Fusezion
reviewed
Oct 17, 2024
No, the owner works whether textures are there or not. |
Efnilite
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Paper does not seem to fetch textures synchronously for skull metas like spigot does, meaning playerprofiles without texture data will resolve to untextured skulls. This forces a synchronous lookup as a non-breaking change when applying skull owners.
It may be better to move this lookup to the original offlineplayer acquisition, opinions welcome.
Target Minecraft Versions: any
Requirements: none
Related Issues: #7068