Custom domain support #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we don't support multiple deployment version at the moment
- Use A record for DNS config - Show verified status in domain list
carmenlau
force-pushed
the
custom-domain
branch
from
81fd925 to
f7ec25e
Compare
kiootic
reviewed
Dec 31, 2019
carmenlau
force-pushed
the
custom-domain
branch
from
f7ec25e to
efed586
Compare
|
@louischan-oursky @kiootic I added a section ced950d to clarify some scenarios (e.g. 2 apps use same root domain) which include what we have discussed, see if it looks good. |
kiootic
reviewed
Jan 2, 2020
louischan-oursky
approved these changes
Jan 2, 2020
kiootic
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect #246
Added the custom domain spec and updated the skycli spec for managing domains commands.