Add Lambda support for Skygear Data Type #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value serializer provides serialization outside the context of a record. It uses include serializing lambda parameters and return values.
cheungpat
force-pushed
the
more-lambda-types
branch
from
b08047a to
bc81286
Compare
carmenlau
requested changes
May 11, 2018
| @Override | ||
| public void onSuccess(JSONObject result) { | ||
| try { | ||
| this.onLambdaSuccess((T)ValueSerializer.deserialize(result)); |
There was a problem hiding this comment.
The result here is the full response payload, I think we should remove the key of "result". Now that we can assign different generic instead of hashmap only?
There was a problem hiding this comment.
oh really? sorry i miss that will fix
Before this commit, the developer has to get the "result" value from a map. This commit changed this behavior so that whatever value is in the "result" key is immediately available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connects #230